ntg-context - mailing list for ConTeXt users
 help / color / mirror / Atom feed
* \basegrid ignores color
@ 2018-03-20 20:51 Henri Menke
  2018-03-22 22:22 ` Henri Menke
  0 siblings, 1 reply; 3+ messages in thread
From: Henri Menke @ 2018-03-20 20:51 UTC (permalink / raw)
  To: mailing list for ConTeXt users

Dear devs,

The \basegrid macro ignores its color option.  That's kind of obvious because as
I look at the code I don't see the color being communicated to Metapost at any
point.  When you're at it, could you please also add a rulethickness parameters?
 Thanks!

Reproducible in TL2018 pertest and latest beta.  MWE is below (as always).

Cheers, Henri

---

\starttext

\basegrid[color=red]

\color[red]{\basegrid}

\stoptext

___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: \basegrid ignores color
  2018-03-20 20:51 \basegrid ignores color Henri Menke
@ 2018-03-22 22:22 ` Henri Menke
  2018-03-23  8:59   ` Hans Hagen
  0 siblings, 1 reply; 3+ messages in thread
From: Henri Menke @ 2018-03-22 22:22 UTC (permalink / raw)
  To: mailing list for ConTeXt users

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Bump!

I attached the updated core file to make it easier for you.

On Wed, 2018-03-21 at 09:51 +1300, Henri Menke wrote:
> Dear devs,
> 
> The \basegrid macro ignores its color option.  That's kind of obvious because
> as
> I look at the code I don't see the color being communicated to Metapost at any
> point.  When you're at it, could you please also add a rulethickness
> parameters?
>  Thanks!
> 
> Reproducible in TL2018 pertest and latest beta.  MWE is below (as always).
> 
> Cheers, Henri
> 
> ---
> 
> \starttext
> 
> \basegrid[color=red]
> 
> \color[red]{\basegrid}
> 
> \stoptext
> 

[-- Attachment #2: meta-grd.mkiv --]
[-- Type: text/x-matlab, Size: 4064 bytes --]

%D \module
%D   [       file=meta-grd,
%D        version=2012.06.28,
%D          title=\METAPOST\ Graphics,
%D       subtitle=grids,
%D         author=Hans Hagen,
%D           date=\currentdate,
%D      copyright={PRAGMA ADE \& \CONTEXT\ Development Team}]
%C
%C This module is part of the \CONTEXT\ macro||package and is
%C therefore copyrighted by \PRAGMA. See mreadme.pdf for
%C details.

\writestatus{loading}{MetaPost Graphics / Grids}

%D This used to be a \TEX\ method, and a rather old one too. We keep it around but
%D in a more modern way.
%D
%D \startbuffer
%D \basegrid
%D   [nx=8,ny=5,
%D    dx=.5,dy=.25,
%D    unit=cm,scale=2,factor=1,
%D    offset=1ex,xstep=2,ystep=1,
%D    align=middle,style=\tt\tx]
%D \stopbuffer
%D
%D \typebuffer
%D
%D \placefigure
%D   {An example of a grid.}
%D   {\getbuffer}

\startuseMPgraphic{grid}{nx,ny,dx,dy,factor,scale,xstep,ystep,xoffset,yoffset,align,rulecolor,rulethickness}
    begingroup ;

        save nx, ny, dx, dy, wd, ht, xstep, ystep, xoffset, yoffset, align, xalign, yalign, rulecolor, rulethickness ;

        numeric nx      ; nx      := \MPvar{nx} ;
        numeric ny      ; ny      := \MPvar{ny} ;
        numeric dx      ; dx      := \MPvar{factor} * \MPvar{scale} * \MPvar{dx} ;
        numeric dy      ; dy      := \MPvar{factor} * \MPvar{scale} * \MPvar{dy} ;
        numeric wd      ; wd      := nx * dx ;
        numeric ht      ; ht      := ny * dy ;
        numeric xstep   ; xstep   := \MPvar{xstep} ;
        numeric ystep   ; ystep   := \MPvar{ystep} ;
        numeric xoffset ; xoffset := \MPvar{xoffset} ;
        numeric yoffset ; yoffset := \MPvar{yoffset} ;
        numeric align   ; align   := \MPvar{align} ;
        color rulecolor ; rulecolor := \MPvar{rulecolor} ;
        numeric rulethickness ; rulethickness := \MPvar{rulethickness} ;
        numeric xalign  ; xalign  := 0 ;
        numeric yalign  ; yalign  := 0 ;

        if align = 1 :
            xalign := dx/2 ;
            yalign := dy/2 ;
        fi ;

        for i=0 step dx until wd :
            draw (i,0) -- (i,ht)
                withpen pencircle scaled rulethickness
                withcolor rulecolor ;
        endfor ;
        for i=0 step dy until ht :
            draw (0,i) -- (wd,i)
                withpen pencircle scaled rulethickness
                withcolor rulecolor ;
        endfor ;

        if xstep > 0 :
            for i=1 step xstep until nx :
                draw thetextext.bot(decimal i,(i*dx-xalign,-xoffset));
            endfor ;
        fi ;
        if ystep > 0 :
            for i=1 step ystep until ny :
                draw thetextext.lft(decimal i,(-yoffset,i*dy-yalign)) ;
            endfor ;
        fi ;

    endgroup ;
\stopuseMPgraphic

\unprotect

\unexpanded\def\basegrid
  {\dosingleempty\typo_grid_base}

\def\typo_grid_base[#1]%
  {\hbox\bgroup
   \getdummyparameters
     [\c!nx=10,\c!ny=10,\c!dx=.5,\c!dy=.5,\c!xstep=0,\c!ystep=0,
      \c!unit=\s!cm,\c!scale=1,\c!factor=1,
      \c!offset=.25ex,\c!xoffset=\directdummyparameter\c!offset,\c!yoffset=\directdummyparameter\c!offset,
      \c!align=,
      \c!rulecolor=\s!black,
      \c!rulethickness=\linewidth,
      #1]%
   \usedummystyleandcolor\c!style\c!color
   \edef\p_align{\directdummyparameter\c!align}%
   \ifx\p_align\v!middle
      \let\p_align\!!plusone
   \else
      \let\p_align\!!zerocount
   \fi
   \useMPgraphic
    {grid}%
    {nx=\directdummyparameter\c!nx,%
     ny=\directdummyparameter\c!ny,%
     dx=\directdummyparameter\c!dx\directdummyparameter\c!unit,%
     dy=\directdummyparameter\c!dy\directdummyparameter\c!unit,%
     factor=\directdummyparameter\c!factor,%
     scale=\directdummyparameter\c!scale,%
     xstep=\directdummyparameter\c!xstep,%
     ystep=\directdummyparameter\c!ystep,%
     xoffset=\directdummyparameter\c!xoffset,%
     yoffset=\directdummyparameter\c!yoffset,%
     align=\p_align,%
     rulecolor=\directdummyparameter\c!rulecolor,%
     rulethickness=\directdummyparameter\c!rulethickness,%
    }%
  \egroup}

\let\grid\basegrid

\protect \endinput

[-- Attachment #3: test.mkvi --]
[-- Type: text/plain, Size: 90 bytes --]

\loadmarkfile{meta-grd}
\starttext
\basegrid[rulecolor=gray,rulethickness=.1pt]
\stoptext

[-- Attachment #4: Type: text/plain, Size: 492 bytes --]

___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: \basegrid ignores color
  2018-03-22 22:22 ` Henri Menke
@ 2018-03-23  8:59   ` Hans Hagen
  0 siblings, 0 replies; 3+ messages in thread
From: Hans Hagen @ 2018-03-23  8:59 UTC (permalink / raw)
  To: ntg-context

On 3/22/2018 11:22 PM, Henri Menke wrote:
> Bump!
> 
> I attached the updated core file to make it easier for you.

juct check the beta when i upload a new one (you might learn a few extra 
tricks)


> On Wed, 2018-03-21 at 09:51 +1300, Henri Menke wrote:
>> Dear devs,
>>
>> The \basegrid macro ignores its color option.  That's kind of obvious because
>> as
>> I look at the code I don't see the color being communicated to Metapost at any
>> point.  When you're at it, could you please also add a rulethickness
>> parameters?
>>   Thanks!
>>
>> Reproducible in TL2018 pertest and latest beta.  MWE is below (as always).
>>
>> Cheers, Henri
>>
>> ---
>>
>> \starttext
>>
>> \basegrid[color=red]
>>
>> \color[red]{\basegrid}
>>
>> \stoptext
>>
>>
>> ___________________________________________________________________________________
>> If your question is of interest to others as well, please add an entry to the Wiki!
>>
>> maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
>> webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
>> archive  : https://bitbucket.org/phg/context-mirror/commits/
>> wiki     : http://contextgarden.net
>> ___________________________________________________________________________________


-- 

-----------------------------------------------------------------
                                           Hans Hagen | PRAGMA ADE
               Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
        tel: 038 477 53 69 | www.pragma-ade.nl | www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-23  8:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20 20:51 \basegrid ignores color Henri Menke
2018-03-22 22:22 ` Henri Menke
2018-03-23  8:59   ` Hans Hagen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).