public inbox archive for pandoc-discuss@googlegroups.com
 help / color / mirror / Atom feed
From: christophe dervieux <christophe.dervieux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: pandoc-discuss <pandoc-discuss-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: How improve syntax highlighter parsing for new operators ?
Date: Thu, 20 May 2021 06:17:46 -0700 (PDT)	[thread overview]
Message-ID: <414226ce-0150-4a82-a692-a185f483abeen@googlegroups.com> (raw)
In-Reply-To: <87o8d5y3ht.fsf-9EawChwDxG8hFhg+JK9F0w@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 2141 bytes --]

Thanks for the confirmation. I'll have a look into KDE files then and 
understand how to improve this. :) 

Also using `--syntax-definition` will help ! Thanks. And will be a very 
good way of providing backward compatibility. Thank you !

Le jeudi 20 mai 2021 à 14:52:12 UTC+2, Albert Krewinkel a écrit :

> Hi Christophe,
>
> christophe dervieux <christoph...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>
> > I wanted to make sure on where to report or look at in order to improve 
> the
> > Pandoc block highlighting.
> >
> > Recent version of R has added new operators. These are not recognized
> > correctly when Pandoc is doing the highlighting. For example `|>` this is
> > now a single operator and not 2 tokens - Pandoc highlights the latter and
> > set two different classes, one for each token leading to two differents
> > colors.
> >
> > I understand that Pandoc highlighting mechanism lives
> > in https://github.com/jgm/skylighting but it seems the definition for
> > parser lives upstream
> > in https://invent.kde.org/frameworks/syntax-highlighting. I got that 
> from
> > the README.
> >
> > Is that right ?
>
> Yes, that's correct.
>
> > If I want to report an improvment request, or get help to make the
> > improvement, should I go in skylighting or upstream and Pandoc will get 
> the
> > update later on ?
>
> Going upstream first would be best, I think. A possibly interesting
> point is also that you won't have to wait for skylighting to update, but
> could ship an updated definition file with R Markdown, then feed it to
> pandoc via `--syntax-definition`.
>
> --
> Albert Krewinkel
> GPG: 8eed e3e2 e8c5 6f18 81fe e836 388d c0b2 1f63 1124
>

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/414226ce-0150-4a82-a692-a185f483abeen%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 3409 bytes --]

      parent reply	other threads:[~2021-05-20 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 12:29 christophe dervieux
     [not found] ` <63c327e2-daff-4e59-bb7f-e194f98dfd81n-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
2021-05-20 12:49   ` Albert Krewinkel
     [not found]     ` <87o8d5y3ht.fsf-9EawChwDxG8hFhg+JK9F0w@public.gmane.org>
2021-05-20 13:17       ` christophe dervieux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414226ce-0150-4a82-a692-a185f483abeen@googlegroups.com \
    --to=christophe.dervieux-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=pandoc-discuss-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).