How improve syntax highlighter parsing for new operators ?

How improve syntax highlighter parsing for new operators ?

[christophe dervieux]

[-- Attachment #1.1: Type: text/plain, Size: 1282 bytes --]

Hi, 

I wanted to make sure on where to report or look at in order to improve the 
Pandoc block highlighting. 

Recent version of R has added new operators. These are not recognized 
correctly when Pandoc is doing the highlighting. For example `|>` this is 
now a single operator and not 2 tokens - Pandoc highlights the latter and 
set two different classes, one for each token leading to two differents 
colors. 

I understand that Pandoc highlighting mechanism lives 
in https://github.com/jgm/skylighting but it seems the definition for 
parser lives upstream 
in https://invent.kde.org/frameworks/syntax-highlighting. I got that from 
the README. 

Is that right ? 

If I want to report an improvment request, or get help to make the 
improvement, should I go in skylighting or upstream and Pandoc will get the 
update later on ? 

Thanks for your help and advices.

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/63c327e2-daff-4e59-bb7f-e194f98dfd81n%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 1707 bytes --]

Re: How improve syntax highlighter parsing for new operators ?

[Albert Krewinkel]

Hi Christophe,

christophe dervieux <christophe.dervieux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> I wanted to make sure on where to report or look at in order to improve the
> Pandoc block highlighting.
>
> Recent version of R has added new operators. These are not recognized
> correctly when Pandoc is doing the highlighting. For example `|>` this is
> now a single operator and not 2 tokens - Pandoc highlights the latter and
> set two different classes, one for each token leading to two differents
> colors.
>
> I understand that Pandoc highlighting mechanism lives
> in https://github.com/jgm/skylighting but it seems the definition for
> parser lives upstream
> in https://invent.kde.org/frameworks/syntax-highlighting. I got that from
> the README.
>
> Is that right ?

Yes, that's correct.

> If I want to report an improvment request, or get help to make the
> improvement, should I go in skylighting or upstream and Pandoc will get the
> update later on ?

Going upstream first would be best, I think. A possibly interesting
point is also that you won't have to wait for skylighting to update, but
could ship an updated definition file with R Markdown, then feed it to
pandoc via `--syntax-definition`.

--
Albert Krewinkel
GPG: 8eed e3e2 e8c5 6f18 81fe  e836 388d c0b2 1f63 1124

Re: How improve syntax highlighter parsing for new operators ?

[christophe dervieux]

[-- Attachment #1.1: Type: text/plain, Size: 2141 bytes --]

Thanks for the confirmation. I'll have a look into KDE files then and 
understand how to improve this. :) 

Also using `--syntax-definition` will help ! Thanks. And will be a very 
good way of providing backward compatibility. Thank you !

Le jeudi 20 mai 2021 à 14:52:12 UTC+2, Albert Krewinkel a écrit :

> Hi Christophe,
>
> christophe dervieux <christoph...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>
> > I wanted to make sure on where to report or look at in order to improve 
> the
> > Pandoc block highlighting.
> >
> > Recent version of R has added new operators. These are not recognized
> > correctly when Pandoc is doing the highlighting. For example `|>` this is
> > now a single operator and not 2 tokens - Pandoc highlights the latter and
> > set two different classes, one for each token leading to two differents
> > colors.
> >
> > I understand that Pandoc highlighting mechanism lives
> > in https://github.com/jgm/skylighting but it seems the definition for
> > parser lives upstream
> > in https://invent.kde.org/frameworks/syntax-highlighting. I got that 
> from
> > the README.
> >
> > Is that right ?
>
> Yes, that's correct.
>
> > If I want to report an improvment request, or get help to make the
> > improvement, should I go in skylighting or upstream and Pandoc will get 
> the
> > update later on ?
>
> Going upstream first would be best, I think. A possibly interesting
> point is also that you won't have to wait for skylighting to update, but
> could ship an updated definition file with R Markdown, then feed it to
> pandoc via `--syntax-definition`.
>
> --
> Albert Krewinkel
> GPG: 8eed e3e2 e8c5 6f18 81fe e836 388d c0b2 1f63 1124
>

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/414226ce-0150-4a82-a692-a185f483abeen%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 3409 bytes --]