Contributing

Contributing

[Erik Rask]

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

Hello,
I'd like to start contributing more. Based on the Readme, a discussion here
first is recommended. The DocBook issues are perhaps my best place to
start. In chronological order, that starts me at issue 1402
<https://github.com/jgm/pandoc/issues/1402> as far as I can tell.

I would say that is best solved by adding role="unnumbered" to the section.
Section labelling (i.e. numbering) is controlled by the XSLT stylesheets in
DocBook, so not numbering an individual section (rather than stop at a
certain depth) would be implemented in a stylesheet customization. But
marking the relevant sections would at least allow a custom stylesheet to
match precisely.

If I recall correctly from the PR for this
<https://github.com/jgm/pandoc/pull/7116>, that would just require putting
("role","unnumbered") in Header.Attr.attributes and it would come out as
the role attribute in DocBook.

Protocol questions for the maintainers:

   1. Would this comment have been better on the GitHub issue?
   2. Do you want issue references GitHub-style in commits to issues (e.g.
   "fixes #1234") from contributors, or do you prefer handling them separately?

Take care.

-- 
Hurrying will get you nowhere faster.

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/CAMXDC9Ky3CfOCpy%3DSbCsaDzZyk%3DDcMCx51wNp%2BoML-9pOcrrYw%40mail.gmail.com.

[-- Attachment #2: Type: text/html, Size: 2359 bytes --]

Re: Contributing

[John MacFarlane]

Great! In this case, I think commenting on the GitHub issue might make more sense, since we’d have the context of the previous discussion.

And yes, you can put “fixes #whatever” in your commit message.


> On Dec 9, 2022, at 12:57 PM, Erik Rask <lifeunleaded-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
> Hello,
> I'd like to start contributing more. Based on the Readme, a discussion here first is recommended. The DocBook issues are perhaps my best place to start. In chronological order, that starts me at issue 1402 as far as I can tell.
> 
> I would say that is best solved by adding role="unnumbered" to the section. Section labelling (i.e. numbering) is controlled by the XSLT stylesheets in DocBook, so not numbering an individual section (rather than stop at a certain depth) would be implemented in a stylesheet customization. But marking the relevant sections would at least allow a custom stylesheet to match precisely.
> 
> If I recall correctly from the PR for this, that would just require putting ("role","unnumbered") in Header.Attr.attributes and it would come out as the role attribute in DocBook.
> 
> Protocol questions for the maintainers: 
> 	• Would this comment have been better on the GitHub issue?
> 	• Do you want issue references GitHub-style in commits to issues (e.g. "fixes #1234") from contributors, or do you prefer handling them separately?
> Take care.
> 
> -- 
> Hurrying will get you nowhere faster.
> 
> -- 
> You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/CAMXDC9Ky3CfOCpy%3DSbCsaDzZyk%3DDcMCx51wNp%2BoML-9pOcrrYw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/56C1D138-581C-4B54-95B5-24AE18D441AD%40gmail.com.