pandoc 2.18 -> 2.19 minor HTML writer difference?

pandoc 2.18 -> 2.19 minor HTML writer difference?

[William Lupton]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

All (but probably mostly John),

This isn't important, but I noticed a minor difference in going from pandoc
2.18 to 2.19 and couldn't see it referenced in the release notes.

I generate this HTML, which is then passed to pandoc and comes out again as
HTML with a ToC:

<h1 class="unnumbered" id="sec:executive-summary">Executive Summary<a
class="headerlink" href="#sec:executive-summary" title="Permalink to this
header"> <img src='permalink.png' title='' width="0.8em"/></a></h1>

With 2.18 the final output (in the ToC) is this:

<li><a href="#sec:executive-summary"
id="toc-sec:executive-summary">Executive Summary <span><img
src="permalink.png" style="width:0.8em" /></span></a></li>

But in 2.19 it's this:

<li><a href="#sec:executive-summary"
id="toc-sec:executive-summary">Executive Summary <img src="permalink.png"
style="width:0.8em" /></a></li>

In the 2.18 output the <img> is in a <span> but in the 2.19 output there's
no <span>. I noticed this because I have CSS to hide the permalink image in
the ToC and this change broke the CSS.

I wondered whether this was an intentional change (of course I prefer not
to have a useless <span>, so I don't object to the change).

Thanks,
William

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/CAEe_xxjNmOcBiH%3DGjmRHxBv4Q5QeCjHDppRex-HY4krgHDf0gg%40mail.gmail.com.

[-- Attachment #2: Type: text/html, Size: 2607 bytes --]

Re: pandoc 2.18 -> 2.19 minor HTML writer difference?

[Gwern Branwen]

That was probably https://github.com/jgm/pandoc/issues/8020 which was
done to remove the useless <span> and remove a possible footgun where
things you don't expect happen to be wrapped in useless <span>s with
no rhyme or reason, yes.

-- 
gwern
https://www.gwern.net

Re: pandoc 2.18 -> 2.19 minor HTML writer difference?

[John MacFarlane]

It's in the changelog, but maybe too compressed to get the message across:

    + `toTableOfContents`: Don't replace links with empty spans in TOC (#8020).



> On Aug 8, 2022, at 1:14 AM, William Lupton <wlupton-QSt+ys/nuMyEUIsrzH9SikB+6BGkLq7r@public.gmane.org> wrote:
> 
> All (but probably mostly John),
> 
> This isn't important, but I noticed a minor difference in going from pandoc 2.18 to 2.19 and couldn't see it referenced in the release notes.
> 
> I generate this HTML, which is then passed to pandoc and comes out again as HTML with a ToC:
> 
> <h1 class="unnumbered" id="sec:executive-summary">Executive Summary<a class="headerlink" href="#sec:executive-summary" title="Permalink to this header"> <img src='permalink.png' title='' width="0.8em"/></a></h1>
> 
> With 2.18 the final output (in the ToC) is this:
> 
> <li><a href="#sec:executive-summary" id="toc-sec:executive-summary">Executive Summary <span><img src="permalink.png" style="width:0.8em" /></span></a></li>
> 
> But in 2.19 it's this:
> 
> <li><a href="#sec:executive-summary" id="toc-sec:executive-summary">Executive Summary <img src="permalink.png" style="width:0.8em" /></a></li>
> 
> In the 2.18 output the <img> is in a <span> but in the 2.19 output there's no <span>. I noticed this because I have CSS to hide the permalink image in the ToC and this change broke the CSS.
> 
> I wondered whether this was an intentional change (of course I prefer not to have a useless <span>, so I don't object to the change).
> 
> Thanks,
> William
> 
> -- 
> You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/CAEe_xxjNmOcBiH%3DGjmRHxBv4Q5QeCjHDppRex-HY4krgHDf0gg%40mail.gmail.com.

Re: pandoc 2.18 -> 2.19 minor HTML writer difference?

[William Lupton]

[-- Attachment #1: Type: text/plain, Size: 3063 bytes --]

Ah. Sorry. I think I was only looking in the HTML writer. Thanks.

On Mon, 8 Aug 2022, 17:22 John MacFarlane, <fiddlosopher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> It's in the changelog, but maybe too compressed to get the message across:
>
>     + `toTableOfContents`: Don't replace links with empty spans in TOC
> (#8020).
>
>
>
> > On Aug 8, 2022, at 1:14 AM, William Lupton <wlupton-QSt+ys/nuMyEUIsrzH9SikB+6BGkLq7r@public.gmane.org>
> wrote:
> >
> > All (but probably mostly John),
> >
> > This isn't important, but I noticed a minor difference in going from
> pandoc 2.18 to 2.19 and couldn't see it referenced in the release notes.
> >
> > I generate this HTML, which is then passed to pandoc and comes out again
> as HTML with a ToC:
> >
> > <h1 class="unnumbered" id="sec:executive-summary">Executive Summary<a
> class="headerlink" href="#sec:executive-summary" title="Permalink to this
> header"> <img src='permalink.png' title='' width="0.8em"/></a></h1>
> >
> > With 2.18 the final output (in the ToC) is this:
> >
> > <li><a href="#sec:executive-summary"
> id="toc-sec:executive-summary">Executive Summary <span><img
> src="permalink.png" style="width:0.8em" /></span></a></li>
> >
> > But in 2.19 it's this:
> >
> > <li><a href="#sec:executive-summary"
> id="toc-sec:executive-summary">Executive Summary <img src="permalink.png"
> style="width:0.8em" /></a></li>
> >
> > In the 2.18 output the <img> is in a <span> but in the 2.19 output
> there's no <span>. I noticed this because I have CSS to hide the permalink
> image in the ToC and this change broke the CSS.
> >
> > I wondered whether this was an intentional change (of course I prefer
> not to have a useless <span>, so I don't object to the change).
> >
> > Thanks,
> > William
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "pandoc-discuss" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/pandoc-discuss/CAEe_xxjNmOcBiH%3DGjmRHxBv4Q5QeCjHDppRex-HY4krgHDf0gg%40mail.gmail.com
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "pandoc-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/pandoc-discuss/E58391EA-2668-4987-9B29-1CC28D5C257A%40gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/CAEe_xxiNcz%2BgJ%3D9OUWKpd1BQFBBpo5ZMN69qSCLm6njRVAZmPg%40mail.gmail.com.

[-- Attachment #2: Type: text/html, Size: 4774 bytes --]