public inbox archive for pandoc-discuss@googlegroups.com
 help / color / mirror / Atom feed
From: Bastien DUMONT <bastien.dumont-VwIFZPTo/vqsTnJN9+BGXg@public.gmane.org>
To: pandoc-discuss-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Walk and deep copy in Lua filters
Date: Sun, 12 Jun 2022 20:41:42 +0000	[thread overview]
Message-ID: <YqZPhvGeWIZaIPct@localhost> (raw)
In-Reply-To: <87tu8pyaur.fsf-9EawChwDxG8hFhg+JK9F0w@public.gmane.org>

OK, thanks! I will submit a pull request tomorrow.

For BPJ: `clone()` returns a deep copy when called on objects, so it could be used in the example I provided. However, they return a shallow copy when called on Lists, which is my real use case. As you can see, the following chunk throws an error:

```
local orig = pandoc.Emph({ pandoc.Str('one'), pandoc.Space(), pandoc.Str('two') }).content
local copy = orig:clone()
copy[1].text = 'first'
assert(orig[1].text == 'one')
```

(In Lua, almost all methods in `table` modify their first argument and return a pointer to it.)

Le Sunday 12 June 2022 à 08:41:06PM, Albert Krewinkel a écrit :
> 
> Bastien DUMONT <bastien.dumont-VwIFZPTo/vqsTnJN9+BGXg@public.gmane.org> writes:
> 
> > I just discovered by chance that the method walk returns a deep copy
> > of the passed object, leaving the original object untouched. [...]
> >
> > [...] Nevertheless, since it is not really documented, can it be
> > considered to be deliberate and stable? If this is the case, could it
> > be possible to make explicit in the documentation, under the header
> > “Result”, that the original block or inline element is left unchanged?
> 
> Yes, this is deliberate and won't change. A PR to improve the docs would
> be very welcome.
> 
> 
> -- 
> Albert Krewinkel
> GPG: 8eed e3e2 e8c5 6f18 81fe  e836 388d c0b2 1f63 1124
> 
> -- 
> You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/87tu8pyaur.fsf%40zeitkraut.de.

-- 
You received this message because you are subscribed to the Google Groups "pandoc-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pandoc-discuss+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web visit https://groups.google.com/d/msgid/pandoc-discuss/YqZPhvGeWIZaIPct%40localhost.


      parent reply	other threads:[~2022-06-12 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 11:16 Bastien DUMONT
2022-06-12 18:00 ` BPJ
2022-06-12 18:41 ` Albert Krewinkel
     [not found]   ` <87tu8pyaur.fsf-9EawChwDxG8hFhg+JK9F0w@public.gmane.org>
2022-06-12 20:41     ` Bastien DUMONT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqZPhvGeWIZaIPct@localhost \
    --to=bastien.dumont-vwifzpto/vqstnjn9+bgxg@public.gmane.org \
    --cc=pandoc-discuss-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).