minor nits picked up by valgrind

[Jeremy Fitzhardinge <jeremy@goop.org>]

Since valgrind[1] came out, I've been applying it to everything I can
think of.  rc was pretty clean, with one actual (but minor) problem and
one non-problem.

The actual problem is that it doesn't clear out the sa_mask when calling
sigaction, which presumably means that there's a random set of signals
masked when calling the signal handler.  I'm assuming this isn't a big
problem.  Maybe it should be sigfillset instead?

The non-problem is that it tries to call sigaction on SIGKILL and
SIGSTOP.  This is ignored by the kernel, but it makes valgrind complain.

Here's a patch for both of these:

--- rc-1.7/signal.c	Thu Nov  1 03:29:10 2001
+++ rc-1.7.jsgf/signal.c	Tue Jul 30 23:08:39 2002
@@ -14,6 +14,7 @@
 
 	new.sa_handler = handler;
 	new.sa_flags = SA_INTERRUPT;
+	sigemptyset(&new.sa_mask);
 	sigaction(signum, &new, &old);
 	return old.sa_handler;
 }
@@ -96,6 +97,8 @@
 #endif
 
 	for (i = 1; i < NUMOFSIGNALS; i++) {
+		if (i == SIGSTOP || i == SIGKILL)
+			continue;
 		h = sys_signal(i, SIG_IGN);
 		if (h != SIG_IGN && h != SIG_ERR)
 			sys_signal(i, h);


    J

1: http://developer.kde.org/~sewardj/