oops, let's try that one again

[Decklin Foster <fosterd@hartwick.edu>]

Decklin Foster writes:

> if (p->w && strspn(p->w, "*") == strlen(p->w) &&
>     p->m && strspn(p->m, "\001") == strlen(p->m))
>         return TRUE;

OK, raise your hand if you can spot the bug here. The test case I came
up with after posting this code, which breaks it, is:

~ () *'*'

(any number of quoted stars will do.) Not a crasher, but still
obviously wrong. Thankfully, the fix involves changing only one
character:

	if (p->w && strspn(p->w, "*") == strlen(p->w) &&
	    p->m && strspn(p->m, "\001") == strlen(p->w))
		return TRUE;

But this of course can be simplified to

	if (p->w && p->m && strspn(p->w, "*") == strspn(p->m, "\001")
					      == strlen(p->w))
		return TRUE;

Which is somewhat more efficient, anyway. If you would like me to stop
thinking aloud, just speak up, but I don't think this list is
suffering from too much traffic ;-)

[Note: my normal style would be to pull "== strlen(p->w))" back to the
first tab stop and then put "return TRUE;" after it on the same line,
but the rc Way seems to be to use

	if (foo)
		bar;

instead of

	if (foo) bar;

which is what I do for short statements. In short, reformat as you see
fit.]

-- 
Written with 100% free software. Please support the following websites:
www.debian.org www.noamazon.com www.gnu.org www.opendvd.org lpf.ai.mit.edu