Re: Bug in builtin wait when there are no kids?

[John Mackin <mackin@vast.eecs.unsw.oz.au>]

Rich has come across one of the many ways to break rc's waiting.  I
wasn't going to talk about this on the list, since I believe that
it's not really the done thing, but as I have explained to Byron
how this needs to be fixed and he has ignored me, I've decided I
need to speak out.

The way rc waits now is totally bogus.  All it takes is an interrupt
at the wrong time and the data structures go to hell.  Another easy way
to provoke it is this (last tried in 1.1gamma):

; fn sigiot { /bin/echo pus; /bin/echo pus }
; kill -6 $pid

Infinite loop.

This really -must- be fixed.  Ignoring this issue isn't an acceptable
solution; neither is adopting the position that since there is no
mutual exclusion in, for example, malloc, the game is over anyway.
In a theoretical sense that is true, but the fact of the matter is
that rc is most likely to receive a signal during wait(), so it is
well worth the effort to use proper data structures that cannot
become corrupted under these conditions.

I do not claim that it is good to have to do this.  I believe that
the way the wait() system call works is quite bad, and presents
difficult problems for shell authors.  I do believe, notwithstanding
that, that it must be done.  Byron, I would appreciate a statement
as to your position on this matter; I know you don't want to do anything
to rc now beyond bug fixes, but I can't believe that you don't agree
that this is a bug.

OK,
John.