From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from archone.tamu.edu ([128.194.53.42]) by hawkwind.utcs.toronto.edu with SMTP id <2694>; Thu, 28 May 1992 12:11:16 -0400 Received: from stolaf.edu ([130.71.128.8]) by archone.tamu.edu with SMTP id <45322>; Thu, 28 May 1992 11:10:55 -0500 Received: from mari.acc.stolaf.edu by stolaf.edu (4.1/SMI-4.1) id AA29694; Thu, 28 May 92 11:06:50 CDT Date: Thu, 28 May 1992 12:06:50 -0400 From: quanstro@stolaf.edu (Erik Quanstrom) Message-Id: <9205281606.AA29694@stolaf.edu> To: Subject: possible bug in dopipe() [walk.c] Apparently-To: It dopipe, 1 is used as a sentinal to mark fd_pref and fd_out as unused. Is it entirely clear that fd 1 will never be used? I would think that -1 (_never_ a legal value for a fd) would be a better choice for the sentinal, or? 298c298 < fd_prev = fd_out = 1; --- > fd_prev = fd_out = -1; 310c310 < if (fd_prev != 1) --- > if (fd_prev != -1) 316c316 < if (fd_prev != 1) --- > if (fd_prev != -1)