rc-list - mailing list for the rc(1) shell
 help / color / mirror / Atom feed
From: culliton@srg.af.mil (Tom Culliton x2278)
To: cks@hawkwind.utcs.toronto.edu, rc@hawkwind.utcs.toronto.edu
Subject: Re: /pub/rc/rc-1.5betadev-1.tar.gz now on ftp.sys.utoronto.ca
Date: Mon, 7 Mar 1994 14:40:00 -0500	[thread overview]
Message-ID: <9403071440.aa07845@ceres.srg.af.mil> (raw)

I forwarded these patches for the readline support to Byron two months
ago but never heard back.  (Possibly an email glitch, or merely that
Byron fell (or was pushed) off the face of the planet again ;-) )  If
you link in readline without these patches, 1) readline doesn't handle
certain signals (e.g. SIGINT) gracefully, 2) trip.rc will fail to
complete successfully.

	From culliton Wed Jan 12 16:36:18 1994
	From: culliton@srg.af.mil (Tom Culliton x2278)
	To: byron@ghoti.netapp.com
	Subject: Re: rc patches halfway to 1.5
	Date: Wed, 12 Jan 94 16:36:18 EST
	Status: RO
	
	> Hm. I don't know about (1), I will have to look through my mail.
	> With regard to (2), could you please let me know which patches
	> are missing so I could put them in?
	
	Sorry this took so long, too many balls in the air and something tends
	to get dropped, as you probably know.  Here's at least one patch that
	was missing.  Without the patch and with readline linked in trip will
	fail when it checks prompting.
	
	Tom
	
	*** input.c~	Mon Jan 10 11:37:57 1994
	--- input.c	Wed Jan 12 16:18:30 1994
	***************
	*** 121,127 ****
	  		while (1) {
	  #ifdef READLINE
	  			if (interactive && istack->fd == 0) {
	! 				rlinebuf = readline(prompt);
	  				if (rlinebuf == NULL) {
	  					chars_in = 0;
	  				} else {
	--- 121,127 ----
	  		while (1) {
	  #ifdef READLINE
	  			if (interactive && istack->fd == 0) {
	! 				rlinebuf = rc_readline(prompt);
	  				if (rlinebuf == NULL) {
	  					chars_in = 0;
	  				} else {
	***************
	*** 279,288 ****
	  			}
	  			if ((s = varlookup("prompt")) != NULL) {
	  #ifdef READLINE
	! 				prompt = s->w;
	! #else
	! 				fprint(2, "%s", s->w);
	  #endif
	  				prompt2 = (s->n == NULL ? "" : s->n->w);
	  			}
	  		}
	--- 279,289 ----
	  			}
	  			if ((s = varlookup("prompt")) != NULL) {
	  #ifdef READLINE
	! 				if (istack->fd == 0)
	! 					prompt = s->w;
	! 				else
	  #endif
	+ 					fprint(2, "%s", s->w);
	  				prompt2 = (s->n == NULL ? "" : s->n->w);
	  			}
	  		}
	***************
	*** 302,307 ****
	--- 303,321 ----
	  	unexcept(); /* eError */
	  	return parsetree;
	  }
	+ 
	+ extern void print_prompt2() {
	+ 	lineno++;
	+ 	if (interactive)
	+ 	{
	+ #ifdef READLINE
	+ 		if (istack->fd == 0)
	+ 			prompt = prompt2;
	+ 		else
	+ #endif
	+ 			fprint(2, "%s", prompt2);
	+ 	}
	+ }
	  
	  /* parse a function imported from the environment */
	  
	*** lex.c~	Mon Jan 10 11:37:58 1994
	--- lex.c	Wed Jan 12 16:18:19 1994
	***************
	*** 336,351 ****
	  		realbuf = ealloc(bufsize);
	  }
	  
	- extern void print_prompt2() {
	- 	lineno++;
	- #ifdef READLINE
	- 	prompt = prompt2;
	- #else
	- 	if (interactive)
	- 		fprint(2, "%s", prompt2);
	- #endif
	- }
	- 
	  /*
	     Scan in a pair of integers for redirections like >[2=1]. CLOSED represents a closed file
	     descriptor (i.e., >[2=]) and UNSET represents an undesignated file descriptor (e.g.,
	--- 336,341 ----
	


             reply	other threads:[~1994-03-07 19:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1994-03-07 19:40 Tom Culliton x2278 [this message]
  -- strict thread matches above, loose matches on Subject: below --
1994-03-07 19:01 Chris Siebenmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9403071440.aa07845@ceres.srg.af.mil \
    --to=culliton@srg.af.mil \
    --cc=cks@hawkwind.utcs.toronto.edu \
    --cc=rc@hawkwind.utcs.toronto.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).