From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pasanda.cygnus.co.uk ([194.130.39.3]) by hawkwind.utcs.utoronto.ca with SMTP id <24735>; Fri, 6 Feb 1998 17:17:21 -0500 Received: (qmail 1317 invoked by alias); 6 Feb 1998 18:01:00 -0000 Received: (qmail 1309 invoked from network); 6 Feb 1998 18:00:59 -0000 Received: from nan.cygnus.co.uk (tgoodwin@194.130.39.19) by dns.cygnus.co.uk with SMTP; 6 Feb 1998 18:00:59 -0000 In-Reply-To: <19980205214831.17917.qmail@np.nosc.mil> Subject: Re: "rc" shell maintainer? To: broman@nosc.mil CC: rc@hawkwind.utcs.toronto.edu Date: Fri, 6 Feb 1998 13:00:37 -0500 From: Tim Goodwin Message-ID: Thanks for the bug report. > I tried out rc-1.5b2 on my SunOS 4.1.3 (with most Sun patches) machine > and gcc-2.7.2, and I got a core dump during trip. Any suggestions? This change looks wrong to me. > - - ngroups = getgroups(0, (gid_t *)0); > + ngroups = getgroups(0, (GETGROUPS_T *)0); There was a bug in rc-1.5b2, but the fix for 1.5b3 will be as appended. (Incidentally, I finally tracked this one down using ElectricFence. Thanks to Bruce Perens for a marvellous piece of software.) Tim. --- release/rc-1.5b2/which.c Mon Jul 7 16:43:32 1997 +++ rc-1.5b3/which.c Thu Feb 5 15:23:59 1998 @@ -88,7 +88,7 @@ gid = getegid(); #if HAVE_GETGROUPS ngroups = getgroups(0, (gid_t *)0); - gidset = malloc(ngroups * sizeof(gid_t)); + gidset = malloc(ngroups * sizeof(GETGROUPS_T)); if (!gidset) uerror("malloc"); else