Re: File descriptor leak.

["David J. Fiander" <golem!david@uunet.UU.NET>]

>From:  "David J. Fiander" <david>
>rc slowly opens, and then forgets about file descriptors when
>one uses the "<{cmd}" construct on a system with /dev/fd.  The
>problem is that glom() calls mkcmdarg(), which creates a pipe,
>forks, sets up the child to read from (or write to) the pipe,
>sets the name of the argument for the parent, and then forgets
>about the file.  After the pipeline has terminated (or rc has

More info:  when using named pipes to do all this, rc maintains
a list of fifo file names which it unlinks after the pipeline
has completed.  The code to build the list is all conditionally
compiled in, but the code to clean up is always there
(fortunately, it sees that there is no list of fifos, and just
returns).  The problem can be fixed by adding code to
mkcmdarg() to maintain the fifoq, so that when the pipeline
terminates, empty_fifoq() will _close_ all the pipes that were
created.

How does that sound?

--
David J. Fiander   |A man ought to read just as inclination leads him; for
<david@golem.uucp> |what he reads as a task will do him little good.