ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:117161] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect`
@ 2024-03-14 11:23 Eregon (Benoit Daloze) via ruby-core
  2024-03-14 11:25 ` [ruby-core:117162] " Eregon (Benoit Daloze) via ruby-core
  2024-09-20 23:33 ` [ruby-core:119276] " jeremyevans0 (Jeremy Evans) via ruby-core
  0 siblings, 2 replies; 3+ messages in thread
From: Eregon (Benoit Daloze) via ruby-core @ 2024-03-14 11:23 UTC (permalink / raw)
  To: ruby-core; +Cc: Eregon (Benoit Daloze)

Issue #20337 has been reported by Eregon (Benoit Daloze).

----------------------------------------
Bug #20337: Complex#inspect mutates the string returned by `real.inspect`
https://bugs.ruby-lang.org/issues/20337

* Author: Eregon (Benoit Daloze)
* Status: Open
* ruby -v: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
```
irb(main):001:0> n = Numeric.new
=> #<Numeric:0x00007f81b2308578>
irb(main):004:0> class Numeric; def inspect = super.freeze; end
=> :inspect
irb(main):006:0> Complex(n, 1).inspect
(irb):6:in `inspect': can't modify frozen String: "#<Numeric:0x00007f81b2308578>" (FrozenError)
        from (irb):6:in `<main>'                                                                        
        from /home/eregon/.rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.6.2/exe/irb:11:in `<top (required)>'
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `load'                                       
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `<main>'             
```

It feels wrong to mutate the result of inspect at least in general, for instance `true.inspect` is frozen.

Discovered by https://github.com/ruby/spec/pull/1142



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:117162] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect`
  2024-03-14 11:23 [ruby-core:117161] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect` Eregon (Benoit Daloze) via ruby-core
@ 2024-03-14 11:25 ` Eregon (Benoit Daloze) via ruby-core
  2024-09-20 23:33 ` [ruby-core:119276] " jeremyevans0 (Jeremy Evans) via ruby-core
  1 sibling, 0 replies; 3+ messages in thread
From: Eregon (Benoit Daloze) via ruby-core @ 2024-03-14 11:25 UTC (permalink / raw)
  To: ruby-core; +Cc: Eregon (Benoit Daloze)

Issue #20337 has been updated by Eregon (Benoit Daloze).


Same for Complex#to_s.

----------------------------------------
Bug #20337: Complex#inspect mutates the string returned by `real.inspect`
https://bugs.ruby-lang.org/issues/20337#change-107251

* Author: Eregon (Benoit Daloze)
* Status: Open
* ruby -v: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
```
irb(main):001:0> n = Numeric.new
=> #<Numeric:0x00007f81b2308578>
irb(main):004:0> class Numeric; def inspect = super.freeze; end
=> :inspect
irb(main):006:0> Complex(n, 1).inspect
(irb):6:in `inspect': can't modify frozen String: "#<Numeric:0x00007f81b2308578>" (FrozenError)
        from (irb):6:in `<main>'                                                                        
        from /home/eregon/.rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.6.2/exe/irb:11:in `<top (required)>'
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `load'                                       
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `<main>'             
```

It feels wrong to mutate the result of inspect at least in general, for instance `true.inspect` is frozen.

Discovered by https://github.com/ruby/spec/pull/1142



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:119276] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect`
  2024-03-14 11:23 [ruby-core:117161] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect` Eregon (Benoit Daloze) via ruby-core
  2024-03-14 11:25 ` [ruby-core:117162] " Eregon (Benoit Daloze) via ruby-core
@ 2024-09-20 23:33 ` jeremyevans0 (Jeremy Evans) via ruby-core
  1 sibling, 0 replies; 3+ messages in thread
From: jeremyevans0 (Jeremy Evans) via ruby-core @ 2024-09-20 23:33 UTC (permalink / raw)
  To: ruby-core; +Cc: jeremyevans0 (Jeremy Evans)

Issue #20337 has been updated by jeremyevans0 (Jeremy Evans).


I submitted a pull request to fix this: https://github.com/ruby/ruby/pull/11657

----------------------------------------
Bug #20337: Complex#inspect mutates the string returned by `real.inspect`
https://bugs.ruby-lang.org/issues/20337#change-109883

* Author: Eregon (Benoit Daloze)
* Status: Open
* ruby -v: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
```
irb(main):001:0> n = Numeric.new
=> #<Numeric:0x00007f81b2308578>
irb(main):004:0> class Numeric; def inspect = super.freeze; end
=> :inspect
irb(main):006:0> Complex(n, 1).inspect
(irb):6:in `inspect': can't modify frozen String: "#<Numeric:0x00007f81b2308578>" (FrozenError)
        from (irb):6:in `<main>'                                                                        
        from /home/eregon/.rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.6.2/exe/irb:11:in `<top (required)>'
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `load'                                       
        from /home/eregon/.rubies/ruby-3.2.2/bin/irb:25:in `<main>'             
```

It feels wrong to mutate the result of inspect at least in general, for instance `true.inspect` is frozen.

Discovered by https://github.com/ruby/spec/pull/1142



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-20 23:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-14 11:23 [ruby-core:117161] [Ruby master Bug#20337] Complex#inspect mutates the string returned by `real.inspect` Eregon (Benoit Daloze) via ruby-core
2024-03-14 11:25 ` [ruby-core:117162] " Eregon (Benoit Daloze) via ruby-core
2024-09-20 23:33 ` [ruby-core:119276] " jeremyevans0 (Jeremy Evans) via ruby-core

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).