* [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
@ 2024-05-21 15:53 lish82 (Hiroki Katagiri) via ruby-core
2024-05-21 19:14 ` [ruby-core:117960] " mame (Yusuke Endoh) via ruby-core
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: lish82 (Hiroki Katagiri) via ruby-core @ 2024-05-21 15:53 UTC (permalink / raw)
To: ruby-core; +Cc: lish82 (Hiroki Katagiri)
Issue #20500 has been reported by lish82 (Hiroki Katagiri).
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:117960] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
@ 2024-05-21 19:14 ` mame (Yusuke Endoh) via ruby-core
2024-05-22 5:43 ` [ruby-core:117964] " nobu (Nobuyoshi Nakada) via ruby-core
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: mame (Yusuke Endoh) via ruby-core @ 2024-05-21 19:14 UTC (permalink / raw)
To: ruby-core; +Cc: mame (Yusuke Endoh)
Issue #20500 has been updated by mame (Yusuke Endoh).
Assignee set to nobu (Nobuyoshi Nakada)
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108377
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:117964] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
2024-05-21 19:14 ` [ruby-core:117960] " mame (Yusuke Endoh) via ruby-core
@ 2024-05-22 5:43 ` nobu (Nobuyoshi Nakada) via ruby-core
2024-05-22 9:20 ` [ruby-core:117965] " lish82 (Hiroki Katagiri) via ruby-core
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: nobu (Nobuyoshi Nakada) via ruby-core @ 2024-05-22 5:43 UTC (permalink / raw)
To: ruby-core; +Cc: nobu (Nobuyoshi Nakada)
Issue #20500 has been updated by nobu (Nobuyoshi Nakada).
Or use `RUBY_CHECK_HEADER` instead of `AC_CHECK_HEADER`?
A question, does enc use jemalloc?
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108383
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:117965] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
2024-05-21 19:14 ` [ruby-core:117960] " mame (Yusuke Endoh) via ruby-core
2024-05-22 5:43 ` [ruby-core:117964] " nobu (Nobuyoshi Nakada) via ruby-core
@ 2024-05-22 9:20 ` lish82 (Hiroki Katagiri) via ruby-core
2024-05-22 9:28 ` [ruby-core:117967] " lish82 (Hiroki Katagiri) via ruby-core
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: lish82 (Hiroki Katagiri) via ruby-core @ 2024-05-22 9:20 UTC (permalink / raw)
To: ruby-core; +Cc: lish82 (Hiroki Katagiri)
Issue #20500 has been updated by lish82 (Hiroki Katagiri).
I don't know if `enc` uses jemalloc actually
But the build of `enc` fails because `-ljemalloc` is specified when building `enc`
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108384
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:117967] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (2 preceding siblings ...)
2024-05-22 9:20 ` [ruby-core:117965] " lish82 (Hiroki Katagiri) via ruby-core
@ 2024-05-22 9:28 ` lish82 (Hiroki Katagiri) via ruby-core
2024-05-23 3:13 ` [ruby-core:117973] " nobu (Nobuyoshi Nakada) via ruby-core
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: lish82 (Hiroki Katagiri) via ruby-core @ 2024-05-22 9:28 UTC (permalink / raw)
To: ruby-core; +Cc: lish82 (Hiroki Katagiri)
Issue #20500 has been updated by lish82 (Hiroki Katagiri).
> Or use `RUBY_CHECK_HEADER` instead of `AC_CHECK_HEADER?`
I think it's enough to solve the first problem (`Non-system directories are not searched when checking jemalloc headers`)
But the process that checks `jemalloc` has a process that checks about library (I'm sorry but I don't know its details),
which expects jemalloc headers to be included in the search path.
So I think that just `RUBY_CHECK_HEADER` might not solve the second problem (Non-system directories are not searched when checking jemalloc libs)
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108386
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:117973] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (3 preceding siblings ...)
2024-05-22 9:28 ` [ruby-core:117967] " lish82 (Hiroki Katagiri) via ruby-core
@ 2024-05-23 3:13 ` nobu (Nobuyoshi Nakada) via ruby-core
2024-05-29 23:53 ` [ruby-core:118085] " k0kubun (Takashi Kokubun) via ruby-core
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: nobu (Nobuyoshi Nakada) via ruby-core @ 2024-05-23 3:13 UTC (permalink / raw)
To: ruby-core; +Cc: nobu (Nobuyoshi Nakada)
Issue #20500 has been updated by nobu (Nobuyoshi Nakada).
Thank you, makes sense.
https://github.com/ruby/ruby/pull/10830
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108393
* Author: lish82 (Hiroki Katagiri)
* Status: Open
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:118085] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (4 preceding siblings ...)
2024-05-23 3:13 ` [ruby-core:117973] " nobu (Nobuyoshi Nakada) via ruby-core
@ 2024-05-29 23:53 ` k0kubun (Takashi Kokubun) via ruby-core
2024-07-15 13:02 ` [ruby-core:118605] " nagachika (Tomoyuki Chikanaga) via ruby-core
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: k0kubun (Takashi Kokubun) via ruby-core @ 2024-05-29 23:53 UTC (permalink / raw)
To: ruby-core; +Cc: k0kubun (Takashi Kokubun)
Issue #20500 has been updated by k0kubun (Takashi Kokubun).
Backport changed from 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: REQUIRED to 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE
ruby_3_3 commit:a96233161a0e917b57c3c2cd9598d75d8b7721f5 merged revision(s) commit:5fa6ba9568e87e43e08a4daeba1572254c589fb1.
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-108512
* Author: lish82 (Hiroki Katagiri)
* Status: Closed
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:118605] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (5 preceding siblings ...)
2024-05-29 23:53 ` [ruby-core:118085] " k0kubun (Takashi Kokubun) via ruby-core
@ 2024-07-15 13:02 ` nagachika (Tomoyuki Chikanaga) via ruby-core
2024-07-15 13:11 ` [ruby-core:118608] " nagachika (Tomoyuki Chikanaga) via ruby-core
2024-10-21 8:50 ` [ruby-core:119554] " nagachika (Tomoyuki Chikanaga) via ruby-core
8 siblings, 0 replies; 10+ messages in thread
From: nagachika (Tomoyuki Chikanaga) via ruby-core @ 2024-07-15 13:02 UTC (permalink / raw)
To: ruby-core; +Cc: nagachika (Tomoyuki Chikanaga)
Issue #20500 has been updated by nagachika (Tomoyuki Chikanaga).
Backport changed from 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE to 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE
ruby_3_2 commit:fc5b9ffad1b0710bd999521d0bf9631af6b762c2 merged revision(s) commit:5fa6ba9568e87e43e08a4daeba1572254c589fb1.
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-109135
* Author: lish82 (Hiroki Katagiri)
* Status: Closed
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:118608] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (6 preceding siblings ...)
2024-07-15 13:02 ` [ruby-core:118605] " nagachika (Tomoyuki Chikanaga) via ruby-core
@ 2024-07-15 13:11 ` nagachika (Tomoyuki Chikanaga) via ruby-core
2024-10-21 8:50 ` [ruby-core:119554] " nagachika (Tomoyuki Chikanaga) via ruby-core
8 siblings, 0 replies; 10+ messages in thread
From: nagachika (Tomoyuki Chikanaga) via ruby-core @ 2024-07-15 13:11 UTC (permalink / raw)
To: ruby-core; +Cc: nagachika (Tomoyuki Chikanaga)
Issue #20500 has been updated by nagachika (Tomoyuki Chikanaga).
Backport changed from 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE to 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE
commit:fc5b9ffad1b0710bd999521d0bf9631af6b762c2 cause compilation failures like `gcc: error: incflags@: No such file or directory`.
Reverted it for a while.
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-109138
* Author: lish82 (Hiroki Katagiri)
* Status: Closed
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ruby-core:119554] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
` (7 preceding siblings ...)
2024-07-15 13:11 ` [ruby-core:118608] " nagachika (Tomoyuki Chikanaga) via ruby-core
@ 2024-10-21 8:50 ` nagachika (Tomoyuki Chikanaga) via ruby-core
8 siblings, 0 replies; 10+ messages in thread
From: nagachika (Tomoyuki Chikanaga) via ruby-core @ 2024-10-21 8:50 UTC (permalink / raw)
To: ruby-core; +Cc: nagachika (Tomoyuki Chikanaga)
Issue #20500 has been updated by nagachika (Tomoyuki Chikanaga).
Backport changed from 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE to 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE
ruby_3_2 commit:e55b1af2573eb21db57a06e5509f9868f288b583, commit:2fbae07c42f40ea43b4822e278cc92fb2415cb61, commit:f70e3254e067663e72e6d410370d231e4245e4f4, commit:db5201ffd531d07747de03c55c4cb1c0e9e5c5bf, commit:fc5b9ffad1b0710bd999521d0bf9631af6b762c2 merged revision(s) commit:ce20367a0e2f1fcfabebf3b6bea732fc71fa79f7.
----------------------------------------
Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc`
https://bugs.ruby-lang.org/issues/20500#change-110171
* Author: lish82 (Hiroki Katagiri)
* Status: Closed
* Assignee: nobu (Nobuyoshi Nakada)
* Backport: 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE
----------------------------------------
I found a problem similar to #20494 on jemalloc
It's similar to #20494, but it has a few more issues
Problems:
- Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494)
- Non-system directories are not searched when checking jemalloc libs
- Non-system directories are not searched when building the `enc` directory sources
I have confirmed that this problem can be fixed by applying the following patch:
```patch
diff --git a/configure.ac b/configure.ac
index 169662c..b2dce70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc],
[with_jemalloc=$withval], [with_jemalloc=no])
AS_IF([test "x$with_jemalloc" != xno],[
# find jemalloc header first
+ save_CPPFLAGS="${CPPFLAGS}"
+ CPPFLAGS="${INCFLAGS} ${CPPFLAGS}"
malloc_header=
AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [
AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h])
@@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[
done
done
])
+ CPPFLAGS="${save_CPPFLAGS}"
+ unset save_CPPFLAGS
with_jemalloc=${rb_cv_jemalloc_library}
AS_CASE(["$with_jemalloc"],
[no],
diff --git a/enc/Makefile.in b/enc/Makefile.in
index 6920bc9..ce93fdd 100644
--- a/enc/Makefile.in
+++ b/enc/Makefile.in
@@ -52,7 +52,7 @@ optflags = @optflags@
debugflags = @debugflags@
warnflags = @warnflags@
CCDLFLAGS = @CCDLFLAGS@
-INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir)
+INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@
DEFS = @DEFS@
CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register
LDFLAGS = @LDFLAGS@
```
---
On a side note, I think there might be other parts affected by the changes bellow:
https://github.com/ruby/ruby/pull/8449
I thought it might be a good idea to review everything thoroughly
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-10-21 9:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 15:53 [ruby-core:117957] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` lish82 (Hiroki Katagiri) via ruby-core
2024-05-21 19:14 ` [ruby-core:117960] " mame (Yusuke Endoh) via ruby-core
2024-05-22 5:43 ` [ruby-core:117964] " nobu (Nobuyoshi Nakada) via ruby-core
2024-05-22 9:20 ` [ruby-core:117965] " lish82 (Hiroki Katagiri) via ruby-core
2024-05-22 9:28 ` [ruby-core:117967] " lish82 (Hiroki Katagiri) via ruby-core
2024-05-23 3:13 ` [ruby-core:117973] " nobu (Nobuyoshi Nakada) via ruby-core
2024-05-29 23:53 ` [ruby-core:118085] " k0kubun (Takashi Kokubun) via ruby-core
2024-07-15 13:02 ` [ruby-core:118605] " nagachika (Tomoyuki Chikanaga) via ruby-core
2024-07-15 13:11 ` [ruby-core:118608] " nagachika (Tomoyuki Chikanaga) via ruby-core
2024-10-21 8:50 ` [ruby-core:119554] " nagachika (Tomoyuki Chikanaga) via ruby-core
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).