ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "AMomchilov (Alexander Momchilov) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "AMomchilov (Alexander Momchilov)" <noreply@ruby-lang.org>
Subject: [ruby-core:118964] [Ruby master Bug#20700] `warn_cr_in_shebang()` doesn't fire if there's no `\n`
Date: Mon, 26 Aug 2024 18:08:04 +0000 (UTC)	[thread overview]
Message-ID: <redmine.issue-20700.20240826180803.51722@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20700.20240826180803.51722@ruby-lang.org>

Issue #20700 has been reported by AMomchilov (Alexander Momchilov).

----------------------------------------
Bug #20700: `warn_cr_in_shebang()` doesn't fire if there's no `\n`
https://bugs.ruby-lang.org/issues/20700

* Author: AMomchilov (Alexander Momchilov)
* Status: Open
* ruby -v: ruby 3.3.4 (2024-07-09 revision be1089c8ec) [arm64-darwin23]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
The `warn_cr_in_shebang()` function looks for `\r\n` together, but the `\r` should emit a warning, regardless if there's also a `\n` or not.

```ruby
#!/usr/bin/ruby

require "tempfile"
require "open3"

def run_rb(ruby_src)
  puts "===== Output of #{ruby_src.inspect}:"
  Tempfile.create("script.rb") do |f|
    f.print(ruby_src)
    f.close
    
    stdout_and_stderr_str, status = Open3.capture2e("/opt/rubies/3.3.4/bin/ruby", f.path)
    raise unless status.success?
    puts stdout_and_stderr_str
  end
end

run_rb("#!ruby")     # ✅ no warning
run_rb("#!ruby\r")   # ❌ no warning!
run_rb("#!ruby\r\n") # ✅ warns
run_rb("#!ruby -Eutf-8\r\n123") # ✅ warns
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

       reply	other threads:[~2024-08-26 18:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 18:08 AMomchilov (Alexander Momchilov) via ruby-core [this message]
2024-08-28  2:31 ` [ruby-core:118972] " nobu (Nobuyoshi Nakada) via ruby-core
2024-08-28  3:17 ` [ruby-core:118973] " nobu (Nobuyoshi Nakada) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.issue-20700.20240826180803.51722@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).