* [ruby-core:119903] [Ruby master Bug#20892] `ObjectSpace.dump` can produce broken JSON for classes with temporary names
@ 2024-11-12 18:47 byroot (Jean Boussier) via ruby-core
2025-01-15 1:46 ` [ruby-core:120680] " k0kubun (Takashi Kokubun) via ruby-core
0 siblings, 1 reply; 2+ messages in thread
From: byroot (Jean Boussier) via ruby-core @ 2024-11-12 18:47 UTC (permalink / raw)
To: ruby-core; +Cc: byroot (Jean Boussier)
Issue #20892 has been reported by byroot (Jean Boussier).
----------------------------------------
Bug #20892: `ObjectSpace.dump` can produce broken JSON for classes with temporary names
https://bugs.ruby-lang.org/issues/20892
* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED
----------------------------------------
```ruby
puts ObjectSpace.dump(Class.new.tap { |c| c.set_temporary_name('" little boby table') })
```
Produces the following JSON:
```json
{
"address":"0x120bea980",
"type":"CLASS",
"shape_id":2,
"slot_size":160,
"class":"0x120bea840",
"variation_count":0,
"superclass":"0x1041ffd38",
"name":"" little boby table",
"references":["0x1041ffd38", "0x123e71a98"],
"memsize":192,
"flags":{"wb_protected":true}
}
```
Notice how the `name` property is broken.
This only impacts 3.3.x, as that's when `set_temporary_name` was introduced, before that, it was impossible to assign a name that would cause such bug.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ruby-core:120680] [Ruby master Bug#20892] `ObjectSpace.dump` can produce broken JSON for classes with temporary names
2024-11-12 18:47 [ruby-core:119903] [Ruby master Bug#20892] `ObjectSpace.dump` can produce broken JSON for classes with temporary names byroot (Jean Boussier) via ruby-core
@ 2025-01-15 1:46 ` k0kubun (Takashi Kokubun) via ruby-core
0 siblings, 0 replies; 2+ messages in thread
From: k0kubun (Takashi Kokubun) via ruby-core @ 2025-01-15 1:46 UTC (permalink / raw)
To: ruby-core; +Cc: k0kubun (Takashi Kokubun)
Issue #20892 has been updated by k0kubun (Takashi Kokubun).
Backport changed from 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE
`ruby_3_3` merged https://github.com/ruby/ruby/pull/12068. Thank you!
----------------------------------------
Bug #20892: `ObjectSpace.dump` can produce broken JSON for classes with temporary names
https://bugs.ruby-lang.org/issues/20892#change-111503
* Author: byroot (Jean Boussier)
* Status: Closed
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE
----------------------------------------
```ruby
puts ObjectSpace.dump(Class.new.tap { |c| c.set_temporary_name('" little boby table') })
```
Produces the following JSON:
```json
{
"address":"0x120bea980",
"type":"CLASS",
"shape_id":2,
"slot_size":160,
"class":"0x120bea840",
"variation_count":0,
"superclass":"0x1041ffd38",
"name":"" little boby table",
"references":["0x1041ffd38", "0x123e71a98"],
"memsize":192,
"flags":{"wb_protected":true}
}
```
Notice how the `name` property is broken.
This only impacts 3.3.x, as that's when `set_temporary_name` was introduced, before that, it was impossible to assign a name that would cause such bug.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-15 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 18:47 [ruby-core:119903] [Ruby master Bug#20892] `ObjectSpace.dump` can produce broken JSON for classes with temporary names byroot (Jean Boussier) via ruby-core
2025-01-15 1:46 ` [ruby-core:120680] " k0kubun (Takashi Kokubun) via ruby-core
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).