From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 18A641F4D0 for ; Wed, 11 Dec 2024 02:06:35 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=YOp7hvXy; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=VLKFZABv; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1733882793; bh=3uW+lwXLsIgGJ6MN6viX0sPJ6ofzFB1TgfD8C8SBHUU=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=YOp7hvXyvEaNQ0a9AJHvCY3216IdjfTcxdClVtz+Ku4MzK+vTx+eRRb4+JIFcZAsH f1pg+dY+EpuRsK+WpjVl5ta282BlMnrK8YcacMXSGd0xPGDrm3BGbawL3WWJa+chwr HVqGWSplj2ocQdkOKXFJWg2TJTbeIpK/+n/ICqdE= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id BA78245F8F for ; Wed, 11 Dec 2024 02:06:33 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=VLKFZABv; dkim-atps=neutral Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 4E672452F2 for ; Wed, 11 Dec 2024 02:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=wSbyro9/7DKcZSgi9CCUoO/EyfvgGLJekDE/neH+EMU=; b=VLKFZABvPf2+BsCe5Ke4iD6yAngnI9Qd8+gdb9ZUKgRroqCpj8CeceM7KVfIIGqzyygr CJ7Ft6bYDGKaY8KpklsaQSzrZx2TyzNvZe13Z8egqHgI8YAI+uvKMPOGfMdLZx5zWqX6ke T3Ydk1NuFCv4kIlSxOEoP9qxqsfKkNlPdJrRhZCF8xCilM6DMdLs1yzq3Od6SRMh4VnXeG cD1fkYagqORowcRHz/qrMr9SKfV2ZT4F9M9KowAdtYfZ28EjlGOZqOPSVH2Ry155ZygV0K 6xWM2tp5y71/kMkTpQO7ZPaA2AedtVyedz92JhLE50CjuolGLM1YrSV96uz00pWg== Received: by recvd-5f54b5d587-dffwj with SMTP id recvd-5f54b5d587-dffwj-1-6758F390-A 2024-12-11 02:06:08.757232979 +0000 UTC m=+2263408.114340311 Received: from herokuapp.com (unknown) by geopod-ismtpd-7 (SG) with ESMTP id feieSDB_TmOsqT9fDZWIMw for ; Wed, 11 Dec 2024 02:06:08.678 +0000 (UTC) Date: Wed, 11 Dec 2024 02:06:08 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20943 X-Redmine-Issue-Author: nobu X-Redmine-Issue-Priority: Normal X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96851 X-SG-EID: =?us-ascii?Q?u001=2E5PtzXJ23KrYzgM1nrOIr+EQ222PyrDaWSg0Er8CZ8tP86xyXmBM81zBKD?= =?us-ascii?Q?HreavdFYMbHjxXOR6UPMkt=2Fu9CyBIp6y52n8D2y?= =?us-ascii?Q?qA9zqurrgUc0wWRAGqGdUWFwOed8ZsH2VGfVmgb?= =?us-ascii?Q?dgK30zHSPzxOVPwH0ao4wOqe+YsOhhIz85bbdoO?= =?us-ascii?Q?OpD+vtQab51A7XU=2FnNoDZ8Wg17Hfxw=2FQn5m7mQ3?= =?us-ascii?Q?DBymGfN=2Fgklv88SPbbbbABEsxXir3clGFfyXad2?= =?us-ascii?Q?wmwjrd1pj6b+GOoREOijsi3dGQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: IADE2L4M2JLYXB4BIGSQOTRYJJO737PI X-Message-ID-Hash: IADE2L4M2JLYXB4BIGSQOTRYJJO737PI X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120174] [Ruby master Bug#20943] Constant defined in `Data` block List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nobu (Nobuyoshi Nakada) via ruby-core" Cc: "nobu (Nobuyoshi Nakada)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20943 has been reported by nobu (Nobuyoshi Nakada). ---------------------------------------- Bug #20943: Constant defined in `Data` block https://bugs.ruby-lang.org/issues/20943 * Author: nobu (Nobuyoshi Nakada) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- >>From https://github.com/ruby/ruby/pull/12274: > A couple times in code review I've seen constants inadvertently leak to top level from within a `Struct` or `Data` do block. I think it would be nice to show reopening the `Data` class when a constant is defined, so the constant is defined within the namespace. In this case, `Measure::NONE` instead of top level `Object::NONE`. It would also show readers that it's okay to reopen a `Data` class, which seems nice since some folk might not realize. Thanks for considering! However, I think that `NONE` probably might be intended to be defined under `Measure`. Current: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define end p NONE #=> NONE ``` Another: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define p NONE #=> Measure::NONE end p NONE # uninitialized constant NONE (NameError) ``` @zverok How do think? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/