[ruby-core:121746] [Ruby Feature#21287] Remove SortedSet autoload and set/sorted_set

[ruby-core:121746] [Ruby Feature#21287] Remove SortedSet autoload and set/sorted_set

[jeremyevans0 (Jeremy Evans) via ruby-core]

Issue #21287 has been reported by jeremyevans0 (Jeremy Evans).

----------------------------------------
Feature #21287: Remove SortedSet autoload and set/sorted_set
https://bugs.ruby-lang.org/issues/21287

* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
----------------------------------------
When implementing core Set, I moved the `SortedSet` autoload from `lib/set.rb` to `prelude.rb`.  However, since this autoload only works if the `sorted_set` gem is installed, I don't think it's a good idea to have in core.  I would like to remove it.  I've submitted a pull request that removes it: https://github.com/ruby/ruby/pull/13188 .

I'm not sure whether people would prefer a deprecation warning before removal, to alert users who have the `sorted_set` gem installed and are relying on the autoload.  Previously, the `SortedSet` autoload was only setup if you had already referenced `Set` to force loading `lib/set.rb`.  So `Set; SortedSet` worked, but `SortedSet; Set` did not. If people would prefer a deprecation warning, I think it's fine to deprecate in 3.5 and remove in 3.6, and I can submit a separate pull request for that approach.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:121923] [Ruby Feature#21287] Remove SortedSet autoload and set/sorted_set

[mame (Yusuke Endoh) via ruby-core]

Issue #21287 has been updated by mame (Yusuke Endoh).


Discussed at the dev meeting, and @matz said "go ahead".



----------------------------------------
Feature #21287: Remove SortedSet autoload and set/sorted_set
https://bugs.ruby-lang.org/issues/21287#change-113031

* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
----------------------------------------
When implementing core Set, I moved the `SortedSet` autoload from `lib/set.rb` to `prelude.rb`.  However, since this autoload only works if the `sorted_set` gem is installed, I don't think it's a good idea to have in core.  I would like to remove it.  I've submitted a pull request that removes it: https://github.com/ruby/ruby/pull/13188 .

I'm not sure whether people would prefer a deprecation warning before removal, to alert users who have the `sorted_set` gem installed and are relying on the autoload.  Previously, the `SortedSet` autoload was only setup if you had already referenced `Set` to force loading `lib/set.rb`.  So `Set; SortedSet` worked, but `SortedSet; Set` did not. If people would prefer a deprecation warning, I think it's fine to deprecate in 3.5 and remove in 3.6, and I can submit a separate pull request for that approach.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/