[ruby-core:108697] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[ruby-core:108697] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[procmarco (Marco Concetto Rudilosso)]

Issue #18805 has been reported by procmarco (Marco Concetto Rudilosso).

----------------------------------------
Bug #18805: IO::Buffer is inconsistent when returning a string from an empty buffer
https://bugs.ruby-lang.org/issues/18805

* Author: procmarco (Marco Concetto Rudilosso)
* Status: Open
* Priority: Normal
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I’ve been using `IO::Buffer` and I found it to be slightly inconsistent when it comes to returning empty string for empty buffers.
for example, a slice of an allocated buffer with `size = 0`, returns `""` with `get_string`, as an example:

```ruby
buffer = IO::Buffer.new(5)
empty_buffer = buffer.slice(0,0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this returns ""
```

but, if you create a buffer with IO::Buffer.new(0) then it stops working

```ruby
empty_buffer = IO::Buffer.new(0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this raises The buffer is not allocated! (IO::Buffer::AllocationError)
```

Is this working as intended? It would be good I think to have a consistent experience where the base case (buffer with size 0) always returns an empty string.
I have a prototype of a possible patch I could send upstream to fix it, which would check the size of the buffer and if 0 it would always return an empty string.



-- 
https://bugs.ruby-lang.org/

[ruby-core:114597] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[jeremyevans0 (Jeremy Evans) via ruby-core]

Issue #18805 has been updated by jeremyevans0 (Jeremy Evans).

Assignee set to ioquatix (Samuel Williams)

@ioquatix Is this expected behavior or a bug?

----------------------------------------
Bug #18805: IO::Buffer is inconsistent when returning a string from an empty buffer
https://bugs.ruby-lang.org/issues/18805#change-104413

* Author: procmarco (Marco Concetto Rudilosso)
* Status: Open
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I’ve been using `IO::Buffer` and I found it to be slightly inconsistent when it comes to returning empty string for empty buffers.
for example, a slice of an allocated buffer with `size = 0`, returns `""` with `get_string`, as an example:

```ruby
buffer = IO::Buffer.new(5)
empty_buffer = buffer.slice(0,0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this returns ""
```

but, if you create a buffer with IO::Buffer.new(0) then it stops working

```ruby
empty_buffer = IO::Buffer.new(0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this raises The buffer is not allocated! (IO::Buffer::AllocationError)
```

Is this working as intended? It would be good I think to have a consistent experience where the base case (buffer with size 0) always returns an empty string.
I have a prototype of a possible patch I could send upstream to fix it, which would check the size of the buffer and if 0 it would always return an empty string.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:115908] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[ioquatix (Samuel Williams) via ruby-core]

Issue #18805 has been updated by ioquatix (Samuel Williams).


This is currently working as intended but we could consider changing the behaviour. I understand the use case.

----------------------------------------
Bug #18805: IO::Buffer is inconsistent when returning a string from an empty buffer
https://bugs.ruby-lang.org/issues/18805#change-105866

* Author: procmarco (Marco Concetto Rudilosso)
* Status: Open
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I’ve been using `IO::Buffer` and I found it to be slightly inconsistent when it comes to returning empty string for empty buffers.
for example, a slice of an allocated buffer with `size = 0`, returns `""` with `get_string`, as an example:

```ruby
buffer = IO::Buffer.new(5)
empty_buffer = buffer.slice(0,0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this returns ""
```

but, if you create a buffer with IO::Buffer.new(0) then it stops working

```ruby
empty_buffer = IO::Buffer.new(0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this raises The buffer is not allocated! (IO::Buffer::AllocationError)
```

Is this working as intended? It would be good I think to have a consistent experience where the base case (buffer with size 0) always returns an empty string.
I have a prototype of a possible patch I could send upstream to fix it, which would check the size of the buffer and if 0 it would always return an empty string.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:116195] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[ioquatix (Samuel Williams) via ruby-core]

Issue #18805 has been updated by ioquatix (Samuel Williams).


As a 2nd issue was created about the similar issue, I think it's worth improving.

See https://github.com/ruby/ruby/pull/9532 for the proposed changes.

----------------------------------------
Bug #18805: IO::Buffer is inconsistent when returning a string from an empty buffer
https://bugs.ruby-lang.org/issues/18805#change-106211

* Author: procmarco (Marco Concetto Rudilosso)
* Status: Open
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I’ve been using `IO::Buffer` and I found it to be slightly inconsistent when it comes to returning empty string for empty buffers.
for example, a slice of an allocated buffer with `size = 0`, returns `""` with `get_string`, as an example:

```ruby
buffer = IO::Buffer.new(5)
empty_buffer = buffer.slice(0,0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this returns ""
```

but, if you create a buffer with IO::Buffer.new(0) then it stops working

```ruby
empty_buffer = IO::Buffer.new(0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this raises The buffer is not allocated! (IO::Buffer::AllocationError)
```

Is this working as intended? It would be good I think to have a consistent experience where the base case (buffer with size 0) always returns an empty string.
I have a prototype of a possible patch I could send upstream to fix it, which would check the size of the buffer and if 0 it would always return an empty string.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:116206] [Ruby master Bug#18805] IO::Buffer is inconsistent when returning a string from an empty buffer

[ioquatix (Samuel Williams) via ruby-core]

Issue #18805 has been updated by ioquatix (Samuel Williams).

Status changed from Open to Closed

Fixed in https://github.com/ruby/ruby/commit/c5cf4d4e129f64cb69aaf0a829aed068ef1943c4

----------------------------------------
Bug #18805: IO::Buffer is inconsistent when returning a string from an empty buffer
https://bugs.ruby-lang.org/issues/18805#change-106225

* Author: procmarco (Marco Concetto Rudilosso)
* Status: Closed
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I’ve been using `IO::Buffer` and I found it to be slightly inconsistent when it comes to returning empty string for empty buffers.
for example, a slice of an allocated buffer with `size = 0`, returns `""` with `get_string`, as an example:

```ruby
buffer = IO::Buffer.new(5)
empty_buffer = buffer.slice(0,0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this returns ""
```

but, if you create a buffer with IO::Buffer.new(0) then it stops working

```ruby
empty_buffer = IO::Buffer.new(0)
puts empty_buffer.size # this prints 0
empty_buffer.get_string # this raises The buffer is not allocated! (IO::Buffer::AllocationError)
```

Is this working as intended? It would be good I think to have a consistent experience where the base case (buffer with size 0) always returns an empty string.
I have a prototype of a possible patch I could send upstream to fix it, which would check the size of the buffer and if 0 it would always return an empty string.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/