ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "ufuk (Ufuk Kayserilioglu) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "ufuk (Ufuk Kayserilioglu)" <noreply@ruby-lang.org>
Subject: [ruby-core:119025] [Ruby master Feature#20712] module should return newly defined module
Date: Tue, 03 Sep 2024 12:14:57 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-109602.20240903121430.53307@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20712.20240903120446.53307@ruby-lang.org>

Issue #20712 has been updated by ufuk (Ufuk Kayserilioglu).


`module` and `class` don't return `nil`, they return the value of the last statement in the scope:
```ruby
x = module Foo
  42
end
puts x #=> 42

x = class Bar
  def foo = 42
end
puts x #=> :foo
```
There might be code that relies on this fact, so the proposal could be a backward compatibility concern.

On the other hand, if this were to change, since method definitions (i.e. `def`s) return the _name_ of the method defined and not the method object itself, I think it would make more sense for `module`/`class` to return the _name_ of the module/class being defined and not the module/class object itself.


----------------------------------------
Feature #20712: module should return newly defined module
https://bugs.ruby-lang.org/issues/20712#change-109602

* Author: esad (Esad Hajdarevic)
* Status: Open
----------------------------------------
Currently module keyword returns nil after defining a new module:

```
x = module Foo
end
# x is nil
```

It would be more consistent with `Module.new` if module keyword returned the newly defined module. Then we could do:

```
using(module Foo
  refine ...
end)
```

instead of

```
module Foo
end
using Foo
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

      parent reply	other threads:[~2024-09-03 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 12:04 [ruby-core:119023] " esad (Esad Hajdarevic) via ruby-core
2024-09-03 12:12 ` [ruby-core:119024] " esad (Esad Hajdarevic) via ruby-core
2024-09-03 12:14 ` ufuk (Ufuk Kayserilioglu) via ruby-core [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-109602.20240903121430.53307@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).