ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "natton (Tien Truong) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "natton (Tien Truong)" <noreply@ruby-lang.org>
Subject: [ruby-core:119079] [Ruby master Bug#20716] Different instance_method behavior in Ruby 2.7 and Ruby 3.x
Date: Fri, 06 Sep 2024 03:42:10 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-109663.20240906034210.53606@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20716.20240906020452.53606@ruby-lang.org>

Issue #20716 has been updated by natton (Tien Truong).


Yes, you are correct. This isn't specific to `define_method`. I modified the snippet a little bit
```
module A
  def test(*args)
    super
  end
end

module B
  def test(a)
    puts a
  end
end

B.prepend(A)

class C
  include B
end

C.new.test(1)
# Ruby 2.7: 1
# Ruby 3.0: 1
# Ruby 3.1: 1

module B
  def test
    puts 'new test'
  end
end

C.new.test
# Ruby 2.7: 'new test'
# Ruby 3.0: wrong number of arguments (given 0, expected 1) (ArgumentError)
# Ruby 3.1: wrong number of arguments (given 0, expected 1) (ArgumentError)
```

----------------------------------------
Bug #20716: Different instance_method behavior in Ruby 2.7 and Ruby 3.x
https://bugs.ruby-lang.org/issues/20716#change-109663

* Author: natton (Tien Truong)
* Status: Open
* ruby -v: 3.3.1
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
Hi, I am working on upgrading our project from 2.7 to 3.x and found a breaking change in `instance_method` behavior.
Here is the code snippet
```
module A
  def test(*args)
    super
  end
end

module B
  def test(a)
    puts a
  end
end

B.prepend(A)

a = lambda do
  puts 'lambda'
end

class C
  include B
end

B.instance_method(:test).bind(C.new).call(1)
# Ruby 2.7: 1
# Ruby 3.0: 1
# Ruby 3.1: 1

B.module_exec do
  define_method(:test, a)
end

B.instance_method(:test).bind(C.new).call
# Ruby 2.7: lambda
# Ruby 3.0: wrong number of arguments (given 0, expected 1) (ArgumentError)
# Ruby 3.1: wrong number of arguments (given 0, expected 1) (ArgumentError)
```
I don't know if this is a bug or a correct intention.

My specs:
- Ruby manager: rbenv
- Tested on 
    - ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux]
    - ruby 3.0.7p220 (2024-04-23 revision 724a071175) [x86_64-linux]
    - ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
    - ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [x86_64-linux]
    - ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux]





-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-09-06  3:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  2:04 [ruby-core:119074] " natton (Tien Truong) via ruby-core
2024-09-06  3:32 ` [ruby-core:119078] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-09-06  3:42 ` natton (Tien Truong) via ruby-core [this message]
2024-09-07  0:00 ` [ruby-core:119094] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-09-09  2:39 ` [ruby-core:119101] " natton (Tien Truong) via ruby-core
2024-09-09  3:27 ` [ruby-core:119102] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-09-10  5:26 ` [ruby-core:119108] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-09-10 14:46 ` [ruby-core:119114] " natton (Tien Truong) via ruby-core
2024-10-21  8:50 ` [ruby-core:119535] " natton (Tien Truong) via ruby-core
2024-10-21  8:50 ` [ruby-core:119545] " nagachika (Tomoyuki Chikanaga) via ruby-core
2024-10-21 15:12 ` [ruby-core:119573] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-10-22  1:51 ` [ruby-core:119584] " natton (Tien Truong) via ruby-core
2024-11-04 22:43 ` [ruby-core:119713] " k0kubun (Takashi Kokubun) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-109663.20240906034210.53606@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).