ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:119165] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3
@ 2024-09-13  4:03 hsbt (Hiroshi SHIBATA) via ruby-core
  2024-09-13  4:10 ` [ruby-core:119166] " k0kubun (Takashi Kokubun) via ruby-core
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: hsbt (Hiroshi SHIBATA) via ruby-core @ 2024-09-13  4:03 UTC (permalink / raw)
  To: ruby-core; +Cc: hsbt (Hiroshi SHIBATA)

Issue #20737 has been reported by hsbt (Hiroshi SHIBATA).

----------------------------------------
Bug #20737: Accidentally changed warning target on Ruby 3.3
https://bugs.ruby-lang.org/issues/20737

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I heard that concern from yhonda.

I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.

https://github.com/ruby/ruby/blob/ruby_3_3/lib/bundled_gems.rb#L29-L34

I should warn them for future update. But this change shouldn't introduce tiny/patch update from 3.3.4.

@k0kubun What's your opinion about that? I will create pull-request if we suppress warns for Ruby 3.5.




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:119166] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3
  2024-09-13  4:03 [ruby-core:119165] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3 hsbt (Hiroshi SHIBATA) via ruby-core
@ 2024-09-13  4:10 ` k0kubun (Takashi Kokubun) via ruby-core
  2024-09-13  5:57 ` [ruby-core:119167] " hsbt (Hiroshi SHIBATA) via ruby-core
  2024-09-13 17:16 ` [ruby-core:119184] " Eregon (Benoit Daloze) via ruby-core
  2 siblings, 0 replies; 4+ messages in thread
From: k0kubun (Takashi Kokubun) via ruby-core @ 2024-09-13  4:10 UTC (permalink / raw)
  To: ruby-core; +Cc: k0kubun (Takashi Kokubun)

Issue #20737 has been updated by k0kubun (Takashi Kokubun).


Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6.

----------------------------------------
Bug #20737: Accidentally changed warning target on Ruby 3.3
https://bugs.ruby-lang.org/issues/20737#change-109745

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I heard that concern from yhonda.

I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.

https://github.com/ruby/ruby/blob/ruby_3_3/lib/bundled_gems.rb#L29-L34

I should warn them for future update. But this change shouldn't introduce tiny/patch update from 3.3.4.

@k0kubun What's your opinion about that? I will create pull-request if we suppress warns for Ruby 3.5.




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:119167] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3
  2024-09-13  4:03 [ruby-core:119165] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3 hsbt (Hiroshi SHIBATA) via ruby-core
  2024-09-13  4:10 ` [ruby-core:119166] " k0kubun (Takashi Kokubun) via ruby-core
@ 2024-09-13  5:57 ` hsbt (Hiroshi SHIBATA) via ruby-core
  2024-09-13 17:16 ` [ruby-core:119184] " Eregon (Benoit Daloze) via ruby-core
  2 siblings, 0 replies; 4+ messages in thread
From: hsbt (Hiroshi SHIBATA) via ruby-core @ 2024-09-13  5:57 UTC (permalink / raw)
  To: ruby-core; +Cc: hsbt (Hiroshi SHIBATA)

Issue #20737 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Closed
Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED

https://github.com/ruby/ruby/pull/11613

----------------------------------------
Bug #20737: Accidentally changed warning target on Ruby 3.3
https://bugs.ruby-lang.org/issues/20737#change-109746

* Author: hsbt (Hiroshi SHIBATA)
* Status: Closed
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED
----------------------------------------
I heard that concern from yhonda.

I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.

https://github.com/ruby/ruby/blob/ruby_3_3/lib/bundled_gems.rb#L29-L34

I should warn them for future update. But this change shouldn't introduce tiny/patch update from 3.3.4.

@k0kubun What's your opinion about that? I will create pull-request if we suppress warns for Ruby 3.5.




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:119184] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3
  2024-09-13  4:03 [ruby-core:119165] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3 hsbt (Hiroshi SHIBATA) via ruby-core
  2024-09-13  4:10 ` [ruby-core:119166] " k0kubun (Takashi Kokubun) via ruby-core
  2024-09-13  5:57 ` [ruby-core:119167] " hsbt (Hiroshi SHIBATA) via ruby-core
@ 2024-09-13 17:16 ` Eregon (Benoit Daloze) via ruby-core
  2 siblings, 0 replies; 4+ messages in thread
From: Eregon (Benoit Daloze) via ruby-core @ 2024-09-13 17:16 UTC (permalink / raw)
  To: ruby-core; +Cc: Eregon (Benoit Daloze)

Issue #20737 has been updated by Eregon (Benoit Daloze).


Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI.

----------------------------------------
Bug #20737: Accidentally changed warning target on Ruby 3.3
https://bugs.ruby-lang.org/issues/20737#change-109766

* Author: hsbt (Hiroshi SHIBATA)
* Status: Closed
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED
----------------------------------------
I heard that concern from yhonda.

I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.

https://github.com/ruby/ruby/blob/ruby_3_3/lib/bundled_gems.rb#L29-L34

I should warn them for future update. But this change shouldn't introduce tiny/patch update from 3.3.4.

@k0kubun What's your opinion about that? I will create pull-request if we suppress warns for Ruby 3.5.




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-13 17:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-13  4:03 [ruby-core:119165] [Ruby master Bug#20737] Accidentally changed warning target on Ruby 3.3 hsbt (Hiroshi SHIBATA) via ruby-core
2024-09-13  4:10 ` [ruby-core:119166] " k0kubun (Takashi Kokubun) via ruby-core
2024-09-13  5:57 ` [ruby-core:119167] " hsbt (Hiroshi SHIBATA) via ruby-core
2024-09-13 17:16 ` [ruby-core:119184] " Eregon (Benoit Daloze) via ruby-core

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).