From: "kddnewton (Kevin Newton) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "kddnewton (Kevin Newton)" <noreply@ruby-lang.org>
Subject: [ruby-core:119223] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler
Date: Mon, 16 Sep 2024 15:16:55 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-109801.20240916151655.3573@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20748.20240916135908.3573@ruby-lang.org>
Issue #20748 has been updated by kddnewton (Kevin Newton).
Assignee set to kddnewton (Kevin Newton)
I have opened a PR for this to match the behavior exactly, but I will say I think Prism's behavior is actually correct here. Right now compile.c results in:
```ruby
puts defined?(undefined_method(){}) # => "expression"
puts defined?(undefined_method(&b)) # => ""
```
whereas Prism results in:
```ruby
puts defined?(undefined_method(){}) # => ""
puts defined?(undefined_method(&b)) # => ""
```
I have updated the code to match compile.c, but I think it's incorrect that we are falling back to "expression" because it has an explicit block versus an implicit one.
----------------------------------------
Bug #20748: Issue with defined? given method call with block in prism compiler
https://bugs.ruby-lang.org/issues/20748#change-109801
* Author: luke-gru (Luke Gruber)
* Status: Open
* Assignee: kddnewton (Kevin Newton)
* ruby -v: 3.4.0dev
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
test.rb
```ruby
puts defined?(undefined_method(){})
```
```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
expression
```
```
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
# empty line
```
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
next prev parent reply other threads:[~2024-09-16 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 13:59 [ruby-core:119219] " luke-gru (Luke Gruber) via ruby-core
2024-09-16 15:16 ` kddnewton (Kevin Newton) via ruby-core [this message]
2024-09-16 15:29 ` [ruby-core:119224] " luke-gru (Luke Gruber) via ruby-core
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-109801.20240916151655.3573@ruby-lang.org \
--to=ruby-core@ml.ruby-lang.org \
--cc=noreply@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).