ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:119219] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler
@ 2024-09-16 13:59 luke-gru (Luke Gruber) via ruby-core
  2024-09-16 15:16 ` [ruby-core:119223] " kddnewton (Kevin Newton) via ruby-core
  2024-09-16 15:29 ` [ruby-core:119224] " luke-gru (Luke Gruber) via ruby-core
  0 siblings, 2 replies; 3+ messages in thread
From: luke-gru (Luke Gruber) via ruby-core @ 2024-09-16 13:59 UTC (permalink / raw)
  To: ruby-core; +Cc: luke-gru (Luke Gruber)

Issue #20748 has been reported by luke-gru (Luke Gruber).

----------------------------------------
Bug #20748: Issue with defined? given method call with block in prism compiler
https://bugs.ruby-lang.org/issues/20748

* Author: luke-gru (Luke Gruber)
* Status: Open
* ruby -v: 3.4.0dev
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
test.rb
```ruby
puts defined?(undefined_method(){})
```

```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
expression
```

```
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
# empty line
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:119223] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler
  2024-09-16 13:59 [ruby-core:119219] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler luke-gru (Luke Gruber) via ruby-core
@ 2024-09-16 15:16 ` kddnewton (Kevin Newton) via ruby-core
  2024-09-16 15:29 ` [ruby-core:119224] " luke-gru (Luke Gruber) via ruby-core
  1 sibling, 0 replies; 3+ messages in thread
From: kddnewton (Kevin Newton) via ruby-core @ 2024-09-16 15:16 UTC (permalink / raw)
  To: ruby-core; +Cc: kddnewton (Kevin Newton)

Issue #20748 has been updated by kddnewton (Kevin Newton).

Assignee set to kddnewton (Kevin Newton)

I have opened a PR for this to match the behavior exactly, but I will say I think Prism's behavior is actually correct here. Right now compile.c results in:

```ruby
puts defined?(undefined_method(){}) # => "expression"
puts defined?(undefined_method(&b)) # => ""
```

whereas Prism results in:

```ruby
puts defined?(undefined_method(){}) # => ""
puts defined?(undefined_method(&b)) # => ""
```

I have updated the code to match compile.c, but I think it's incorrect that we are falling back to "expression" because it has an explicit block versus an implicit one.

----------------------------------------
Bug #20748: Issue with defined? given method call with block in prism compiler
https://bugs.ruby-lang.org/issues/20748#change-109801

* Author: luke-gru (Luke Gruber)
* Status: Open
* Assignee: kddnewton (Kevin Newton)
* ruby -v: 3.4.0dev
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
test.rb
```ruby
puts defined?(undefined_method(){})
```

```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
expression
```

```
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
# empty line
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:119224] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler
  2024-09-16 13:59 [ruby-core:119219] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler luke-gru (Luke Gruber) via ruby-core
  2024-09-16 15:16 ` [ruby-core:119223] " kddnewton (Kevin Newton) via ruby-core
@ 2024-09-16 15:29 ` luke-gru (Luke Gruber) via ruby-core
  1 sibling, 0 replies; 3+ messages in thread
From: luke-gru (Luke Gruber) via ruby-core @ 2024-09-16 15:29 UTC (permalink / raw)
  To: ruby-core; +Cc: luke-gru (Luke Gruber)

Issue #20748 has been updated by luke-gru (Luke Gruber).


I agree it's weird but it could cause an incompatibility I guess, `defined?()` is a weird one for sure.

----------------------------------------
Bug #20748: Issue with defined? given method call with block in prism compiler
https://bugs.ruby-lang.org/issues/20748#change-109802

* Author: luke-gru (Luke Gruber)
* Status: Open
* Assignee: kddnewton (Kevin Newton)
* ruby -v: 3.4.0dev
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
test.rb
```ruby
puts defined?(undefined_method(){})
```

```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
expression
```

```
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
# empty line
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-16 15:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-16 13:59 [ruby-core:119219] [Ruby master Bug#20748] Issue with defined? given method call with block in prism compiler luke-gru (Luke Gruber) via ruby-core
2024-09-16 15:16 ` [ruby-core:119223] " kddnewton (Kevin Newton) via ruby-core
2024-09-16 15:29 ` [ruby-core:119224] " luke-gru (Luke Gruber) via ruby-core

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).