From: "kddnewton (Kevin Newton) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "kddnewton (Kevin Newton)" <noreply@ruby-lang.org>
Subject: [ruby-core:119229] [Ruby master Bug#20747] [prism] regression in retry precedence
Date: Mon, 16 Sep 2024 19:28:19 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-109810.20240916192819.7941@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20747.20240916082642.7941@ruby-lang.org>
Issue #20747 has been updated by kddnewton (Kevin Newton).
I have opened a PR to fix this: https://github.com/ruby/prism/pull/3073.
----------------------------------------
Bug #20747: [prism] regression in retry precedence
https://bugs.ruby-lang.org/issues/20747#change-109810
* Author: byroot (Jean Boussier)
* Status: Open
* Assignee: kddnewton (Kevin Newton)
* ruby -v: ruby 3.4.0dev (2024-09-15T01:06:11Z master 532af89e3b) +PRISM [arm64-darwin23]
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONTNEED
----------------------------------------
Since prism has been made the default, our test suite now fail to boot with the following error:
```ruby
syntax error found (SyntaxError)
298 | raise e
299 | else
> 300 | retry
| ^~~~~ Invalid retry after else
301 | end
302 | end
```
Here's the code in question, that reproduce the error:
```ruby
def retry_thing(times: 1)
retries ||= 0
begin
yield
rescue RuntimeError => e
raise if (retries += 1) > times
begin
refresh!
rescue
raise e
else
retry
end
end
end
```
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2024-09-16 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 8:26 [ruby-core:119214] " byroot (Jean Boussier) via ruby-core
2024-09-16 14:41 ` [ruby-core:119221] " luke-gru (Luke Gruber) via ruby-core
2024-09-16 19:28 ` kddnewton (Kevin Newton) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-109810.20240916192819.7941@ruby-lang.org \
--to=ruby-core@ml.ruby-lang.org \
--cc=noreply@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).