ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "Eregon (Benoit Daloze) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "Eregon (Benoit Daloze)" <noreply@ruby-lang.org>
Subject: [ruby-core:119322] [Ruby master Feature#6012] Proc#source_location also return the column
Date: Fri, 27 Sep 2024 15:21:15 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-109936.20240927152115.59@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-6012.20120214091730.59@ruby-lang.org>

Issue #6012 has been updated by Eregon (Benoit Daloze).


I also really like @ioquatix 's suggestion in https://bugs.ruby-lang.org/issues/6012#note-13 and it is a lot more flexible and more efficient too (since computing e.g. column information if unused is not cheap).
For instance `method.source.code` is great because it completely hides the details how to get the source code and slice it.
TruffleRuby currently keeps the source code in memory and so could provide this automatically without needing to reread the file from disk.
CRuby keeps it but only if `RubyVM.keep_script_lines = true`, so then could use that if available and automatically fallback to read the file from disk (great, because we should avoid users/gems referring to `RubyVM` in their code).

One question is where would we place/how would we name this class?
We could reuse `Thread::Backtrace::Location` as it's quite similar and already has `path`, `lineno`.
But it's not really related to a backtrace here.
Still it seems quite a good fit, and I don't have much idea where to place it otherwise (top-level `Source` seems way too prone for conflicts).

I think in term of the interface we should have:
* start_line
* start_column
* start_offset
* end_line
* end_column
* end_offset
* code: gets the source of the Proc/Method/UnboundMethod

----------------------------------------
Feature #6012: Proc#source_location also return the column
https://bugs.ruby-lang.org/issues/6012#change-109936

* Author: rogerdpack (Roger Pack)
* Status: Assigned
* Assignee: nobu (Nobuyoshi Nakada)
----------------------------------------
As originally suggested in http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/42418

Suggestion/feature request:
have #source_location also return the beginning column where it was defined.
["test.rb", 8, 33]

Thanks!
-roger-




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-09-27 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-6012.20120214091730.59@ruby-lang.org>
2024-09-27 15:06 ` [ruby-core:119320] " Eregon (Benoit Daloze) via ruby-core
2024-09-27 15:21 ` Eregon (Benoit Daloze) via ruby-core [this message]
2025-01-05 14:05 ` [ruby-core:120485] " Eregon (Benoit Daloze) via ruby-core
2025-01-05 21:06 ` [ruby-core:120489] " bkuhlmann (Brooke Kuhlmann) via ruby-core
2025-01-09 11:26 ` [ruby-core:120566] " nobu (Nobuyoshi Nakada) via ruby-core
2025-01-09 11:51 ` [ruby-core:120572] " mame (Yusuke Endoh) via ruby-core
2025-01-09 14:31 ` [ruby-core:120576] " Eregon (Benoit Daloze) via ruby-core
2025-01-09 15:55 ` [ruby-core:120581] " Dan0042 (Daniel DeLorme) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-109936.20240927152115.59@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).