From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 14A7E1F5CB for ; Mon, 30 Sep 2024 09:29:52 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=VmCuW5sF; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=QevDodxS; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1727688560; bh=EM7V/KY9x03gl/2qHRgM2/TokL3/3CQXARLfu5zOIJA=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=VmCuW5sF0cCFXvU8d6RH0S6C37TqXVGzTBJc1drD/4h2Aq1NXM9gsCGLrqXHfg3EK jW2K8Db5MRu9bkFrpf/Ha9/d3fa4nlgbvWABDDOPHNszd/L6+RoWnLcqbExj9+SmWp ileVr0D6N22eRo4Qvg77x2+zLFdzBn7icuqbWQrk= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 4F66E43F67 for ; Mon, 30 Sep 2024 09:29:20 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=QevDodxS; dkim-atps=neutral Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 6095D43F1D for ; Mon, 30 Sep 2024 09:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=X9sx9W5n87M7hALHYkHxhVLSM+ejTDU55kRYFu0Ub18=; b=QevDodxSFPPPXJhXMDRmiHNn1uj7F+d6nBlRwA+PezXvh3xupO4WNq6qR/iNPNTTQ6wI Sa55MYFOfeGYVFPKobEi0/Xceoo87d8DqtiUzQDTDLZIqbbo0fxNInjVcJj298iqswNfH5 Yno0ei7aFMrGcQOtEcyjpQUF0tVK2aRHzz3+DPa8lia+0wYd4jK6NjsL3ElB2gO4vgL/xT HbAcBd59fW2ndqRLvYP86ZBZ7zgy8Js+G2G5RLRcNiD6OmT0ZNEvo3b9u9O6LS38+N414P iRyH+Znaj1SADfM3KpR6Eliz8m7+oQkKLl7EvMJGD8zR9ljZrneblmmNXFGbPNhQ== Received: by recvd-7cc7f7d978-65285 with SMTP id recvd-7cc7f7d978-65285-1-66FA6F62-18 2024-09-30 09:29:06.59602986 +0000 UTC m=+1524733.793882371 Received: from herokuapp.com (unknown) by geopod-ismtpd-0 (SG) with ESMTP id GZK68eqgRbqnPVOXp1l2NQ for ; Mon, 30 Sep 2024 09:29:06.477 +0000 (UTC) Date: Mon, 30 Sep 2024 09:29:06 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20714 X-Redmine-Issue-Author: Earlopain X-Redmine-Issue-Assignee: hsbt X-Redmine-Issue-Priority: Normal X-Redmine-Sender: Earlopain X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 95994 X-SG-EID: =?us-ascii?Q?u001=2EeN8dK4P86Am4z06GVDKdfvEyoI3WQjPfTcd7CtGb2eN1eriElpjSWp5GJ?= =?us-ascii?Q?vSR=2FvvdvOqED6rgnv4GFThyvgwcpj0hCz72HtSf?= =?us-ascii?Q?EcV5vbPqBxzmR7hSDdNVDfXCuPFeOZ2tpCmg8mP?= =?us-ascii?Q?ftMkh8clajurrzmHYxa2WNYn34nrVg0R6jYQynE?= =?us-ascii?Q?=2FZzhGrHyRPpgA2tcEbR2lA+7SRbfdwknDAE8oSn?= =?us-ascii?Q?Slmpoqr5HNPrevRiIHGhSWpM4K5O8r+6EUAnQGb?= =?us-ascii?Q?eGNV?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: AXIJAQBGHN2UVP4QNI64NMWSAUK3CDTT X-Message-ID-Hash: AXIJAQBGHN2UVP4QNI64NMWSAUK3CDTT X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:119357] [Ruby master Bug#20714] Handle optional dependencies in `bundled_gems.rb` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Earlopain (A S) via ruby-core" Cc: "Earlopain (A S)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20714 has been updated by Earlopain (A S). I apologize for my tone, I will try to be more understanding. I am just a bit frustrated with the warnings in general, especially with the ones that were backported 3.3.5. I know it is already reverted but they do still happen now. It would have been nicer if you instead made your changes as a PR so that others could have given feedback instead of checking latest commits and writing about it here after. Anyways, let's see if others have an opinion. I'll just take it as it comes now. ---------------------------------------- Bug #20714: Handle optional dependencies in `bundled_gems.rb` https://bugs.ruby-lang.org/issues/20714#change-109969 * Author: Earlopain (A S) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) * ruby -v: 3.3.5 * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I've encountered a few places around bundled gems where the library doesn't care if the gem is available, but will still provide some functionallity if it is. The way to accomplish that right now seems to be by setting `$VERBOSE = nil` and resetting it later again to not bother the user with the warning about the gem. However, this has the effect of silencing the warning about other gems as well, that may not be prepared about the bundling. >>From `ruby/reline` for example: https://github.com/ruby/reline/blob/c90f08f7e308d2f1cdd7cfaf9939fe45ce546fd2/lib/reline/terminfo.rb#L1-L15 Or the `logging` gem: https://github.com/TwP/logging/blob/df41715364f7eb8c65098cd3c3316677ef1f3784/lib/logging.rb#L9-L15 I propose to simply delay the warning to the next require. GitHub PR at https://github.com/ruby/ruby/pull/11545 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/