ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "ioquatix (Samuel Williams) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "ioquatix (Samuel Williams)" <noreply@ruby-lang.org>
Subject: [ruby-core:119360] [Ruby master Bug#20753] [doc] IO::Buffer examples try to write into readonly buffer returned from IO::Buffer.for
Date: Mon, 30 Sep 2024 12:22:46 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-109972.20240930122246.13465@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20753.20240918101703.13465@ruby-lang.org>

Issue #20753 has been updated by ioquatix (Samuel Williams).


https://github.com/ruby/ruby/pull/11737

----------------------------------------
Bug #20753: [doc] IO::Buffer examples try to write into readonly buffer returned from IO::Buffer.for
https://bugs.ruby-lang.org/issues/20753#change-109972

* Author: hanazuki (Kasumi Hanazuki)
* Status: Open
* Assignee: ioquatix (Samuel Williams)
* ruby -v: ruby 3.4.0dev (2024-09-18T02:16:22Z master 4797b0704a) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
`IO::Buffer.for` without a block returns a readonly `IO::Buffer`. Some examples in the documentation for `IO::Buffer` write into the readonly buffers, which actually raise an `IO::Buffer::AccessError`.

>From `IO::Buffer#clear`:
> ```
> buffer = IO::Buffer.for('test')
> # =>
> #   <IO::Buffer 0x00007fca40087c38+4 SLICE>
> #   0x00000000  74 65 73 74         test
>
> buffer.clear
> # =>
> #   <IO::Buffer 0x00007fca40087c38+4 SLICE>
> #   0x00000000  00 00 00 00         ....
> ```

>From `IO::Buffer#copy`:
> ```
> string= "data:    "
> # => "data:    "
> buffer = IO::Buffer.for(string)
> buffer.copy(IO::Buffer.for("test"), 5)
> # => 4
> ```

And `IO::Buffer#slice`, which should be fixed along with its implementation #20752



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-09-30 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 10:17 [ruby-core:119250] " hanazuki (Kasumi Hanazuki) via ruby-core
2024-09-30  5:19 ` [ruby-core:119346] " mame (Yusuke Endoh) via ruby-core
2024-09-30 12:22 ` ioquatix (Samuel Williams) via ruby-core [this message]
2024-11-05 15:52 ` [ruby-core:119737] " ioquatix (Samuel Williams) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-109972.20240930122246.13465@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).