From: "kddnewton (Kevin Newton) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "kddnewton (Kevin Newton)" <noreply@ruby-lang.org>
Subject: [ruby-core:119407] [Ruby master Bug#20776] [PRISM] Pattern matching syntax error message
Date: Wed, 02 Oct 2024 16:13:17 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-110022.20241002161317.4@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20776.20241002115149.4@ruby-lang.org>
Issue #20776 has been updated by kddnewton (Kevin Newton).
What's happening with the error message is that it's seeing the `$g` and determining that it's not a valid pattern, so it assumes the pattern is missing. Then it's determining that there is no statement delimiter (newline or semicolon) between the statements, so it's saying it expected and end-of-input. Then it's finding the `$g` at the beginning of the next expression, so it's warning that it's possibly useless. Effectively it's parsing it like:
```ruby
1 => <missing>
$g
```
I'm happy to change the error message to whatever would make that more clear.
The second newline is in there because it looked weird having errors hang off the end without another line indicating where the input ended, but I can remove that.
----------------------------------------
Bug #20776: [PRISM] Pattern matching syntax error message
https://bugs.ruby-lang.org/issues/20776#change-110022
* Author: nobu (Nobuyoshi Nakada)
* Status: Open
* Assignee: prism
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: UNKNOWN
----------------------------------------
Syntax error is fine, but is really expecting end-of-input there?
```
$ ruby -v -e '1 => $g'
ruby 3.4.0dev (2024-10-01T14:59:58Z master 169a5ee99e) +PRISM [arm64-darwin23]
-e:1: warning: possibly useless use of a variable in void context
-e: -e:1: syntax errors found (SyntaxError)
> 1 | 1 => $g
| ^~ unexpected global variable, expecting end-of-input
| ^~ expected a pattern expression after `=>`
2 |
```
And the line 2 is **not** in the input.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2024-10-02 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 11:51 [ruby-core:119401] " nobu (Nobuyoshi Nakada) via ruby-core
2024-10-02 11:53 ` [ruby-core:119402] " nobu (Nobuyoshi Nakada) via ruby-core
2024-10-02 16:13 ` kddnewton (Kevin Newton) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-110022.20241002161317.4@ruby-lang.org \
--to=ruby-core@ml.ruby-lang.org \
--cc=noreply@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).