From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D9C6E1F4BE for ; Mon, 21 Oct 2024 09:08:24 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=vwmvKF0Q; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=dTymYTJN; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1729501702; bh=okz5d/hzkACkOu5pqzoCB6/uaFp9ld8JIiPNPQb8hl4=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=vwmvKF0QtFVOsP7ss/emblGM/+MSCyd8xP54m9LhyQnF4TPs0mVzvDRNEKJzo1nfq rsoo+fvIsY7mmz6JqBNlT4+ckQXeNBnP0e9e0t/ycu7BVXvp8hOZwbgE0JDvff3sjB x/PRNS1XodDGZhA0oRbEWPQRIT1OrqiVUJqNQCks= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 89CAA464F1 for ; Mon, 21 Oct 2024 09:08:22 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=dTymYTJN; dkim-atps=neutral Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) by nue.mailmanlists.eu (Postfix) with ESMTPS id C110344506 for ; Mon, 21 Oct 2024 08:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=hD3oCWPlHJQN+rDu7KEDualm2FzmBx39N2o9ReiS5J0=; b=dTymYTJNF8D7pmWZ6lVUWkAf6ggN3/PFsygo7vmleD2c2y9qA3ZTH+3BQ7HFVrWYI/kK oKhZEq+TMbM/946fDyiaeiNQfyJK6ood6DXT2UQxEIrimgmWjH3vxYDnWI8yc4cEHTFWFQ x1bw825TkOGrmq/DOEWvM6vViLgfRvgxRyL2EVcoP9iGRbA4ZHhwy0bB7sn5WXmzcn8aEg AcOD/rWMesK4TTu2V1DyHDFdbsPrldfksxmiE2dc6FeRf8w9dEvVauyZWESE6olKUsolUi W0eKilFwmNF/ieXV85Loo1OSS9sdQRPJUpze6eI/qnWvz2l/HMSX3AwPy1hbIiOg== Received: by recvd-5577bcb48c-6l4d8 with SMTP id recvd-5577bcb48c-6l4d8-1-671615CC-28 2024-10-21 08:50:20.743053785 +0000 UTC m=+3336743.778093775 Received: from herokuapp.com (unknown) by geopod-ismtpd-30 (SG) with ESMTP id Ow0O5JzxS2y3UwN3ervoFg for ; Mon, 21 Oct 2024 08:50:20.730 +0000 (UTC) Date: Mon, 21 Oct 2024 08:50:20 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20500 X-Redmine-Issue-Author: lish82 X-Redmine-Issue-Assignee: nobu X-Redmine-Issue-Priority: Normal X-Redmine-Sender: nagachika X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96188 X-SG-EID: =?us-ascii?Q?u001=2E44VQVH0G4ktThU9FFZyDXb=2FoLGKi0xg3KhKXpO+IAEE5wRGZS=2FaUmrCxU?= =?us-ascii?Q?vRSr0kI+o91vm0PKZJNpskxVPGLEUY0z2=2FFYkjb?= =?us-ascii?Q?KjL91GsNRUA3iz6vBLIvPHLp+vzdiW1r0Cq+YVR?= =?us-ascii?Q?whXvBSPqOBjRwgYlwPs=2FgXxvhV+jyIk78no7dV7?= =?us-ascii?Q?Y6dK6r+XSA6eeLPopmwNmvo=2Frb2wVTtmTkGiNpb?= =?us-ascii?Q?=2Fl6wMvZ+QQGBWkMKGUVaZu5zCDG9HvL62l40L7o?= =?us-ascii?Q?xz8LzNAzl7inHCEAFMOdvaMreA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: XJWATHTXA4Z4QG62ZIV3PLQWCM243X5D X-Message-ID-Hash: XJWATHTXA4Z4QG62ZIV3PLQWCM243X5D X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:119554] [Ruby master Bug#20500] Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nagachika (Tomoyuki Chikanaga) via ruby-core" Cc: "nagachika (Tomoyuki Chikanaga)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20500 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: DONE to 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE ruby_3_2 commit:e55b1af2573eb21db57a06e5509f9868f288b583, commit:2fbae07c42f40ea43b4822e278cc92fb2415cb61, commit:f70e3254e067663e72e6d410370d231e4245e4f4, commit:db5201ffd531d07747de03c55c4cb1c0e9e5c5bf, commit:fc5b9ffad1b0710bd999521d0bf9631af6b762c2 merged revision(s) commit:ce20367a0e2f1fcfabebf3b6bea732fc71fa79f7. ---------------------------------------- Bug #20500: Non-system directories are not searched when checking for jemalloc headers and libs, and building `enc` https://bugs.ruby-lang.org/issues/20500#change-110171 * Author: lish82 (Hiroki Katagiri) * Status: Closed * Assignee: nobu (Nobuyoshi Nakada) * Backport: 3.1: UNKNOWN, 3.2: DONE, 3.3: DONE ---------------------------------------- I found a problem similar to #20494 on jemalloc It's similar to #20494, but it has a few more issues Problems: - Non-system directories (specified by `--with-opt-dir`) are not searched when checking jemalloc headers (almost the same as #20494) - Non-system directories are not searched when checking jemalloc libs - Non-system directories are not searched when building the `enc` directory sources I have confirmed that this problem can be fixed by applying the following patch: ```patch diff --git a/configure.ac b/configure.ac index 169662c..b2dce70 100644 --- a/configure.ac +++ b/configure.ac @@ -1392,6 +1392,8 @@ AC_ARG_WITH([jemalloc], [with_jemalloc=$withval], [with_jemalloc=no]) AS_IF([test "x$with_jemalloc" != xno],[ # find jemalloc header first + save_CPPFLAGS="${CPPFLAGS}" + CPPFLAGS="${INCFLAGS} ${CPPFLAGS}" malloc_header= AC_CHECK_HEADER(jemalloc/jemalloc.h, [malloc_header=jemalloc/jemalloc.h], [ AC_CHECK_HEADER(jemalloc.h, [malloc_header=jemalloc.h]) @@ -1423,6 +1425,8 @@ AS_IF([test "x$with_jemalloc" != xno],[ done done ]) + CPPFLAGS="${save_CPPFLAGS}" + unset save_CPPFLAGS with_jemalloc=${rb_cv_jemalloc_library} AS_CASE(["$with_jemalloc"], [no], diff --git a/enc/Makefile.in b/enc/Makefile.in index 6920bc9..ce93fdd 100644 --- a/enc/Makefile.in +++ b/enc/Makefile.in @@ -52,7 +52,7 @@ optflags = @optflags@ debugflags = @debugflags@ warnflags = @warnflags@ CCDLFLAGS = @CCDLFLAGS@ -INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) +INCFLAGS = -I. -I$(arch_hdrdir) -I$(hdrdir) -I$(top_srcdir) @incflags@ DEFS = @DEFS@ CPPFLAGS = @CPPFLAGS@ -DONIG_ENC_REGISTER=rb_enc_register LDFLAGS = @LDFLAGS@ ``` --- On a side note, I think there might be other parts affected by the changes bellow: https://github.com/ruby/ruby/pull/8449 I thought it might be a good idea to review everything thoroughly -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/