ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "byroot (Jean Boussier) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "byroot (Jean Boussier)" <noreply@ruby-lang.org>
Subject: [ruby-core:119577] [Ruby master Bug#20808] Cannot override Data#inspect
Date: Mon, 21 Oct 2024 16:45:42 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-110196.20241021164542.54539@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20808.20241021162417.54539@ruby-lang.org>

Issue #20808 has been updated by byroot (Jean Boussier).


The `pp` implementation for  `Struct` and `Data` both assume all member readers are public:

```ruby
class Struct # :nodoc:
  def pretty_print(q) # :nodoc:
    q.group(1, sprintf("#<struct %s", PP.mcall(self, Kernel, :class).name), '>') {
      q.seplist(PP.mcall(self, Struct, :members), lambda { q.text "," }) {|member|
        q.breakable
        q.text member.to_s
        q.text '='
        q.group(1) {
          q.breakable ''
          q.pp self[member]
        }
      }
    }
  end

  def pretty_print_cycle(q) # :nodoc:
    q.text sprintf("#<struct %s:...>", PP.mcall(self, Kernel, :class).name)
  end
end

class Data # :nodoc:
  def pretty_print(q) # :nodoc:
    q.group(1, sprintf("#<data %s", PP.mcall(self, Kernel, :class).name), '>') {
      q.seplist(PP.mcall(self, Data, :members), lambda { q.text "," }) {|member|
        q.breakable
        q.text member.to_s
        q.text '='
        q.group(1) {
          q.breakable ''
          q.pp public_send(member)
        }
      }
    }
  end

  def pretty_print_cycle(q) # :nodoc:
    q.text sprintf("#<data %s:...>", PP.mcall(self, Kernel, :class).name)
  end
end if "3.2" <= RUBY_VERSION
```


----------------------------------------
Bug #20808: Cannot override Data#inspect
https://bugs.ruby-lang.org/issues/20808#change-110196

* Author: maicolben (Maicol Bentancor)
* Status: Open
* ruby -v: 3.3.5
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
Given the next code:
```
Dog = Data.define(:name) do
  def inspect
    "Hello!"
  end

  private
  attr_reader :name
end

Dog.new(name: "Fido")
```

It throws an error:
- An error occurred when inspecting the object: #<NoMethodError: private method `name' called for an instance of Dog> 

And isn't using my `inspect` function



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-10-21 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 16:24 [ruby-core:119575] " maicolben (Maicol Bentancor) via ruby-core
2024-10-21 16:43 ` [ruby-core:119576] " byroot (Jean Boussier) via ruby-core
2024-10-21 16:45 ` byroot (Jean Boussier) via ruby-core [this message]
2024-10-21 16:49 ` [ruby-core:119578] " byroot (Jean Boussier) via ruby-core
2024-10-21 18:15 ` [ruby-core:119579] " byroot (Jean Boussier) via ruby-core
2024-10-22  0:12 ` [ruby-core:119582] " mame (Yusuke Endoh) via ruby-core
2024-11-07 10:39 ` [ruby-core:119805] [Ruby master Bug#20808] Data#pretty_print doesn't handle private or remove attribute readers mame (Yusuke Endoh) via ruby-core
2024-11-07 10:57 ` [ruby-core:119808] " byroot (Jean Boussier) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-110196.20241021164542.54539@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).