From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BC7D81F4C1 for ; Wed, 13 Nov 2024 09:12:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=1YlBYDCq; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ju97KmAg; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1731489164; bh=uTLmi53LbL86EmZ/S8klYHu0oAvKnoTtU6mAmpEfkLg=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=1YlBYDCqOqIjP+l9SrRcBEV8E7b6nNPjOcEXgic/98iH0l91putDTYex/bnVFDR6K Z4Afi9IvU1y3aSSFBma7yYqdVmnhh8Snz0hBUKMI9vRiFNT/hjxO0179p3TqrkrT3z 1j/WRmjkVXzAdJDlY+vOR1s0aN439ZLlRIox4Sk8= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id E56C844BE7 for ; Wed, 13 Nov 2024 09:12:44 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ju97KmAg; dkim-atps=neutral Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 9CB7444B31 for ; Wed, 13 Nov 2024 09:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=eTkBJO6tJQJTkjD7KpmqDFEJLXXasTZvOtbJwCou1dQ=; b=Ju97KmAgOdXOvunfMTv9XpXK9CllkGmkK5XCx1xVQ8a/tuudLbroCzhs3dP9F8aEH91I GsxA6hfkhnmmSOiyYY8vl5koOEudGvtMQPgrnG02q686jl3Pd4WyRDBo9MdbgnMSyXY8sY CQTB8EQf7v7V9hHVMQcwmu1ILNDkBEB1gJ5vjA0QQYlq6qQwyya+bgcc92oOG9wtiRAgM8 MJAlu+ilsgJss9eeBUQm6c9qO0QYschxwW9/NqPqi5ob02ls3bHNPiaT/mFFqVAC+A6BbH M/+P/wjZ8Mr8IgEvaEqpSNmd8hZM4aDOWyK+tAUdEwTmRNfQDwj1Y7ypkKCxnnGw== Received: by recvd-canary-549799f6fd-b2mc5 with SMTP id recvd-canary-549799f6fd-b2mc5-1-67346D80-16 2024-11-13 09:12:32.437013532 +0000 UTC m=+5325396.634750039 Received: from herokuapp.com (unknown) by geopod-ismtpd-15 (SG) with ESMTP id 4-NGPKhhS5GjX8Rz-9iCQg for ; Wed, 13 Nov 2024 09:12:32.415 +0000 (UTC) Date: Wed, 13 Nov 2024 09:12:32 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20714 X-Redmine-Issue-Author: Earlopain X-Redmine-Issue-Assignee: hsbt X-Redmine-Issue-Priority: Normal X-Redmine-Sender: deivid X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96584 X-SG-EID: =?us-ascii?Q?u001=2EylzRTT3GG24XITUBroBe7Vu=2FcLwq5cTmVTMQhzlQkRs17HzFdvuwXQJs4?= =?us-ascii?Q?1gUmHQW7OnijYNkHuUORvf3qUg8Tnf1Kh9GJGL0?= =?us-ascii?Q?PTkPY2BITp0XICCfY4tTR3QqO3vcx0ejU3u2duz?= =?us-ascii?Q?E=2FQRlrXjoqb9VwDzkAQI68B3=2FCiJF0k=2FxyxveQS?= =?us-ascii?Q?cAiFgCk172RUCip9oHbOCP+tddkhTm3IM8sDyNa?= =?us-ascii?Q?bBxeEYoH4jBhGw6VQYkcPEl=2Frxmv0vJ5f6jE7q=2F?= =?us-ascii?Q?gNcS?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: XB4G5UPJYIU5KUOIQUD2F5D7TMIL7F7N X-Message-ID-Hash: XB4G5UPJYIU5KUOIQUD2F5D7TMIL7F7N X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:119913] [Ruby master Bug#20714] Handle optional dependencies in `bundled_gems.rb` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: deivid via ruby-core Cc: deivid Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Issue #20714 has been updated by deivid (David Rodr=EDguez). @hsbt My patch in https://github.com/ruby/ruby/pull/11550 seems to work cor= rectly, though, right? I understand the concern of bumping multiple rubies = at a time, skipping warnings, but I think the benefits it provides (handlin= g optional dependencies correctly) overcome this potential issue. ---------------------------------------- Bug #20714: Handle optional dependencies in `bundled_gems.rb` https://bugs.ruby-lang.org/issues/20714#change-110634 * Author: Earlopain (Earlopain _) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) * ruby -v: 3.3.5 * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I've encountered a few places around bundled gems where the library doesn't= care if the gem is available, but will still provide some functionallity i= f it is. The way to accomplish that right now seems to be by setting `$VERBOSE =3D n= il` and resetting it later again to not bother the user with the warning ab= out the gem. However, this has the effect of silencing the warning about ot= her gems as well, that may not be prepared about the bundling.=20 >>From `ruby/reline` for example: https://github.com/ruby/reline/blob/c90f08f= 7e308d2f1cdd7cfaf9939fe45ce546fd2/lib/reline/terminfo.rb#L1-L15 Or the `logging` gem: https://github.com/TwP/logging/blob/df41715364f7eb8c6= 5098cd3c3316677ef1f3784/lib/logging.rb#L9-L15 I propose to simply delay the warning to the next require. GitHub PR at https://github.com/ruby/ruby/pull/11545 --=20 https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.rub= y-lang.org/