From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 796D31F4C1 for ; Tue, 19 Nov 2024 20:36:24 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=QWBw1RvU; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ci5XwtM5; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1732048551; bh=lXE1EGFMgNfR2lCjLLRyuVrBcLex20EqckDWNzwSeXs=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=QWBw1RvUOFswoJzxXkCaCmVJQgSGOGS7EFxrjfDOftxPIN55PFF07s4a0xppcdliD WZBw7jUzmWdNBHKCewJEajgQPHzu+DT6NmDuip/XnVThl0HArKNjcL2cPYEs3iltR1 0xABZVy4tugzgy5+ZnJhQ/Ap0YpvMiPIv3qezns0= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id AC30744BA0 for ; Tue, 19 Nov 2024 20:35:51 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ci5XwtM5; dkim-atps=neutral Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 6785D44885 for ; Tue, 19 Nov 2024 20:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=u9e1pR+yPaYATdb0PS8IY7erushVDFIkwFbm/qEHqwU=; b=Ci5XwtM51mMiHtoaTTciVxvwnDbPlMug5kDC7Qocg1dmK43gA7kck/2dwObOvhPaLFRf lTHSJ7OHPu97H85nab5ayGS/W7ixTlW5eJno5yhiZRFgE0m6a0WxyAkUrdmkcxWtdOM2Uu Zy30Fy8M0Bf48gwEph0b6nMed4R5pZqhTYx4YCqKI2uGFqmB7pNzpEKHDVq4XFGsC+16Zk VqzL/+QyaZXZpVKy2HyRNdJuqpaQJFmiH2zn7QRp+fDl6jtqGISOXtOXWOoTSaDmbvnKfH YvDqgp0BCfGHUpgKZxmKs13wqWr8cw4z+EsKCUIvNVspdU8ZSKdOYZZi0rafWJyw== Received: by recvd-5f9ffdf494-kf2p5 with SMTP id recvd-5f9ffdf494-kf2p5-1-673CF69C-26 2024-11-19 20:35:40.314819297 +0000 UTC m=+429470.835298044 Received: from herokuapp.com (unknown) by geopod-ismtpd-29 (SG) with ESMTP id zKkEFv4PSfuIF4jP6AkJlg for ; Tue, 19 Nov 2024 20:35:40.278 +0000 (UTC) Date: Tue, 19 Nov 2024 20:35:40 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20871 X-Redmine-Issue-Author: sanderd17 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96645 X-SG-EID: =?us-ascii?Q?u001=2ELyyp8a6L4BPdoBZ5kcNQuEdalXgUnCKLcPykf2c9d2sTWfvALBzqM4Ij+?= =?us-ascii?Q?Jg9Prp2eVDkf9lIZhzc05KfUT4Npfgnigb95d+v?= =?us-ascii?Q?hGuAMoCQYcIm8atAr7phmJ=2Fow7zfZlrxVbGkVPy?= =?us-ascii?Q?XQuZwUF0gRcz2Om47v0MXbdASwtliqo9wcqW9UQ?= =?us-ascii?Q?Zy3jWK0Y325KiBc8k2b6VhPCZGh9srAWfY97mCa?= =?us-ascii?Q?4SqJw5vI1bsrib06TBUsV=2FN4mBhkgU1BHAj2SqG?= =?us-ascii?Q?KDUlmN0QBAsi8uZp6Uybd39Yww=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: 7AIIZPO45N6NQC2TTL2TE5CYKB6ILTNT X-Message-ID-Hash: 7AIIZPO45N6NQC2TTL2TE5CYKB6ILTNT X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:119970] [Ruby master Bug#20871] Including methods in Enumerable doesn't make them available in Array List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "jeremyevans0 (Jeremy Evans) via ruby-core" Cc: "jeremyevans0 (Jeremy Evans)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20871 has been updated by jeremyevans0 (Jeremy Evans). I was able to reproduce this but in Ruby 3.2.6, 3.3.6, and master. Backing out commit:6118e8a47394409b53164b60e79fadf348b97db3 (the commit to master that commit:edeb0319f7a95dfe3f9b895bcf32371dd8514726 was based on), fixes the problem, so I was too quick to dismiss that as a cause. My apologies for that. We could revert commit:6118e8a47394409b53164b60e79fadf348b97db3 in master (with similar reverts for 3.2 and 3.3), and reopen #20716. Looking at the change in commit:6118e8a47394409b53164b60e79fadf348b97db3, it seems like adding module Foo to the subclasses list is breaking something. I'm not sure when I'll have time to try to fix this, it might not be until next month. So if anyone else has time and can find a way to fix #20716 without causing the breakage in this issue, that would be awesome. ---------------------------------------- Bug #20871: Including methods in Enumerable doesn't make them available in Array https://bugs.ruby-lang.org/issues/20871#change-110706 * Author: sanderd17 (Sander Deryckere) * Status: Open * ruby -v: 3.3.6 * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Today, our CI pipeline started failing after the automatic update from v3.3.5 to v3.3.6. After researching, it turned out that our core extensions to the `Array` class weren't loaded anymore. The core-extensions code looks like this: ```ruby module CoreExt module Enumerable def average sum(&:to_f) / count if any? end # def ... end end Enumerable.include CoreExt::Enumerable ``` After some debugging, it turned out that the `average` method was included in the `instance_methods` of `Enumerable`, but not in the `instance_methods` of `Array`. Explicitly adding `Array.include CoreExt::Enumerable` fixes CI for our case. The very strange thing is that it only happens on a release branch we are still maintaining. It doesn't happen on our main development branch (which also updated to v3.3.6 today). I have been unable to find the difference between both branches so far (they diverged a couple of months ago, but the base system is still regularly updated on both, and pretty similar). After some digging around, I assume this commit is related to our issue: https://github.com/ruby/ruby/commit/edeb0319f7a95dfe3f9b895bcf32371dd8514726 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/