From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 53D601F4C1 for ; Wed, 20 Nov 2024 18:23:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=NoPfnj1i; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=fYDmc4ZC; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1732127007; bh=S2+2+BIgvwhGDqFgdW2FG5e5PbVarrWiob0KkdkwvvI=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=NoPfnj1i2oy9SKVh5r2cS7bN6Q+DwJQQOih+Z4KEHXEnm1KFzNPObSHgd5dyBSh+F W9/362xEZsQqQgn3WEcjsC4wAdYcGiwX80B565FAfNHV4yWUEKykDmKBwOvozmVxne NkGPH9jirRcVK+m38Djag+EqSDRvmcdJluaumuHc= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 3BCAB44BD8 for ; Wed, 20 Nov 2024 18:23:27 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=fYDmc4ZC; dkim-atps=neutral Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by nue.mailmanlists.eu (Postfix) with ESMTPS id F20DC44B9A for ; Wed, 20 Nov 2024 18:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=wO8L3rszGrdfaETI54Vs3stySW580zF0Y0BC8xf+6+8=; b=fYDmc4ZCnP4shHHvMI4fQZ8hiF1rsd6msmYyPiof9Y1st8taAYm5xcKTIxNc0KfIEi+w ATHkv64Afk3tX393uKzmZuKGZ7ZM3f+ogsC7+jiQWxQt9nDUi3np2LYiQdku0Ma5dQ1b5k LbvMCJLuM+s+BjyO+vELae0tvG8Zhl7KEBFGOZlbhS0v6MFYDchN9gxnLypz61LYn2ZY4n qAzCFf1wa6++1KjOGRwCutSZnPqRTTTXzNIpkohE8A6edIWI46QPHdM3oscve7XxrF44oo +4XJVLNvysr2Uzm0ZU8jzsq3GDPKQj/H+23kqLhyK7edUUWrBqEkS6SFc7xqC67A== Received: by recvd-5f9ffdf494-dflbw with SMTP id recvd-5f9ffdf494-dflbw-1-673E2912-2E 2024-11-20 18:23:14.691567751 +0000 UTC m=+507965.936674249 Received: from herokuapp.com (unknown) by geopod-ismtpd-23 (SG) with ESMTP id oj_rt7dSSpmIVbRZTBdbkw for ; Wed, 20 Nov 2024 18:23:14.659 +0000 (UTC) Date: Wed, 20 Nov 2024 18:23:14 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20871 X-Redmine-Issue-Author: sanderd17 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: sanderd17 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96651 X-SG-EID: =?us-ascii?Q?u001=2EGVZzRnrRlk0QOwritE1xd3zUmFjgHvTYllep2muUlP3YJ0v2GPjWgc0=2FE?= =?us-ascii?Q?+BpEH1=2FMWEOBHmvfYQ2pBXwJi7NTJ=2FKo4UkHuw+?= =?us-ascii?Q?cOPvnrQ9J544dahyjV0hf7vJfGKiVEYyV1W7Dlw?= =?us-ascii?Q?6SswkVvI77q9aaBQpcOilYBwz1MWSJ+dr9SEqDL?= =?us-ascii?Q?dV6D7Hh+twqAG6mEQzM81zrU96p8wgbFWQ=2F5OmU?= =?us-ascii?Q?8py+1TG24aYg8NSl2+DB6p6aOConWjfUSA2iHJj?= =?us-ascii?Q?iUDHB39cKgmNik6azJb1jJlMPQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: ZLRLSJH5H6NQZIAYVOTOGDKXMQUKXB3P X-Message-ID-Hash: ZLRLSJH5H6NQZIAYVOTOGDKXMQUKXB3P X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:119976] [Ruby master Bug#20871] Including methods in Enumerable doesn't make them available in Array List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "sanderd17 (Sander Deryckere) via ruby-core" Cc: "sanderd17 (Sander Deryckere)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20871 has been updated by sanderd17 (Sander Deryckere). So the bug has always been present, but was hidden by a different caching issue. Great find, wouldn't have known where to start. Thank you so much for taking this up so quickly! ---------------------------------------- Bug #20871: Including methods in Enumerable doesn't make them available in Array https://bugs.ruby-lang.org/issues/20871#change-110714 * Author: sanderd17 (Sander Deryckere) * Status: Closed * ruby -v: 3.3.6 * Backport: 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- Today, our CI pipeline started failing after the automatic update from v3.3.5 to v3.3.6. After researching, it turned out that our core extensions to the `Array` class weren't loaded anymore. The core-extensions code looks like this: ```ruby module CoreExt module Enumerable def average sum(&:to_f) / count if any? end # def ... end end Enumerable.include CoreExt::Enumerable ``` After some debugging, it turned out that the `average` method was included in the `instance_methods` of `Enumerable`, but not in the `instance_methods` of `Array`. Explicitly adding `Array.include CoreExt::Enumerable` fixes CI for our case. The very strange thing is that it only happens on a release branch we are still maintaining. It doesn't happen on our main development branch (which also updated to v3.3.6 today). I have been unable to find the difference between both branches so far (they diverged a couple of months ago, but the base system is still regularly updated on both, and pretty similar). After some digging around, I assume this commit is related to our issue: https://github.com/ruby/ruby/commit/edeb0319f7a95dfe3f9b895bcf32371dd8514726 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/