From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E92441F4CC for ; Wed, 11 Dec 2024 10:29:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=nMmGIGdv; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=FfvOirgc; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1733912991; bh=hi8irro9gxFBfuHzHUoARbHTAXaLzF2+a/TTz0aDfnY=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=nMmGIGdvzQ2Cl9iuzGy6Hb/otHd7Rg7sh/vNafpuKpewgqlQkg7jZAW8LEt2Tczlj dDSg50U/ByYtmE9mRzIxxSfG3UpKpt8X7e5tEwnCrITS/b1e6Q5mh2eKxwtODTyz4d ymf2hqUC0dqs0Hnw0a/SVhRFNT8Wwq8STCeT6fYI= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 7C42B44D94 for ; Wed, 11 Dec 2024 10:29:51 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=FfvOirgc; dkim-atps=neutral Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 4874144BBB for ; Wed, 11 Dec 2024 10:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=rCud/5sd33zgyRlYXiSZL7GvGUP31PT0DO/eewp20fs=; b=FfvOirgcTjAcphK0aY3eUnpt4WM0wR/prScPn/rnW6apAVnYLR7B3dAnHDJjuIdPlEiW /bJb6b9MG0s46i3OeC+k7bnUXfN4Foy1qImtqhb/S+h9cRLOjmG3/SXPqt5W5MbcdDu6Bl WShbIFQm4DEiERsFgKIo8k8R9uNy6MYc7+JORSZM6l6kBe5N3vUrzGO8XL6wdRlgB3H+ho fSAe4xORYbF8GLQBZaVVajiowfn3BWknQv24bncTHmcsuhq0VN3lqVwsqUo7tSboTQikS9 If2KcPhYfkocus17BSFz1eFovbKgXLGM3Ru3Pvq757Omv5Ab4PAbrh6h54LU7AEg== Received: by recvd-5f54b5d587-6btv9 with SMTP id recvd-5f54b5d587-6btv9-1-67596991-22 2024-12-11 10:29:37.790056495 +0000 UTC m=+2293539.869481738 Received: from herokuapp.com (unknown) by geopod-ismtpd-0 (SG) with ESMTP id KlFSn91STFa1wemOiAEG3A for ; Wed, 11 Dec 2024 10:29:37.690 +0000 (UTC) Date: Wed, 11 Dec 2024 10:29:37 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20943 X-Redmine-Issue-Author: nobu X-Redmine-Issue-Priority: Normal X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96853 X-SG-EID: =?us-ascii?Q?u001=2EKmNZ1u3n1vIpO8NNTdp+Q9c0ai7potxbEDLMO7SOJO=2F4KkRUz0d23466m?= =?us-ascii?Q?naiq=2F5fmA4hb60MdRMUAwHZnjIWVFu=2FrqiBOz5c?= =?us-ascii?Q?nOvkBudsSThYZyAX5+9=2F=2Ff=2FoQT6MuGd9ouM2heU?= =?us-ascii?Q?3P=2F74ehTtRoSfFcT=2F3V2nBrka7taUhgXwugRL1n?= =?us-ascii?Q?2nQTcrUN7Uctl9WTcX4MUBA=2FUA9MlqjX4rgdJPc?= =?us-ascii?Q?hgMWjQDTimiFSJJbe=2FH6kgOQ5mZ3mElVkpnHI1A?= =?us-ascii?Q?7dmB91LwzhUiOq1XHm1rDbj5sA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: ZUVA34IUB7V5KFMXZ73M6MU5VY5THYEV X-Message-ID-Hash: ZUVA34IUB7V5KFMXZ73M6MU5VY5THYEV X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120176] [Ruby master Bug#20943] Constant defined in `Data.define` block List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "byroot (Jean Boussier) via ruby-core" Cc: "byroot (Jean Boussier)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20943 has been updated by byroot (Jean Boussier). Yeah, that's a common mistake with `Struct.new` / `Data.define` / `Class.new` That's why with `Struct` you'd often see: ```ruby class Something < Struct.new(:a, :b) ... end ``` Which is a bit wasteful as you define two classes instead of one, but not a big deal. I kinda wish this would be valid syntax: ```ruby class Something = Struct.new(:a, :b) ... end ``` ---------------------------------------- Bug #20943: Constant defined in `Data.define` block https://bugs.ruby-lang.org/issues/20943#change-110934 * Author: nobu (Nobuyoshi Nakada) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- >>From https://github.com/ruby/ruby/pull/12274: > A couple times in code review I've seen constants inadvertently leak to top level from within a `Struct` or `Data` do block. I think it would be nice to show reopening the `Data` class when a constant is defined, so the constant is defined within the namespace. In this case, `Measure::NONE` instead of top level `Object::NONE`. It would also show readers that it's okay to reopen a `Data` class, which seems nice since some folk might not realize. Thanks for considering! However, I think that `NONE` probably might be intended to be defined under `Measure`. Current: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define end p NONE #=> NONE ``` Another: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define p NONE #=> Measure::NONE end p NONE # uninitialized constant NONE (NameError) ``` @zverok How do think? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/