From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C7E4F1F4CC for ; Wed, 18 Dec 2024 06:14:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=dZkalzZS; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=IxW1Irik; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1734502414; bh=NVMuLhcEnLVWAlfbIxzSMvAekHlMwTvBWJaml0K/VGI=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=dZkalzZSML228uMvqgewqYtgHtCVfaZZxxyYGePX2vB06r7EWMiaZ0VgBR7UW3yWa fFR8qcoXssZTB6r8oVyWk2mR6QofmStfgsqt6Dl6GgTeWshOMjII9Hx+Nv4oKQqNEf mb+8SZzsIq9biIvyFm9ca5qbczrLcglXcdpBtD5s= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 5AC2E45F51 for ; Wed, 18 Dec 2024 06:13:34 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=IxW1Irik; dkim-atps=neutral Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) by nue.mailmanlists.eu (Postfix) with ESMTPS id F164544CD0 for ; Wed, 18 Dec 2024 06:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=jzSLVrKP2EhuKPbpySgwNOZ2sTiJ6wOmG3fVLIy6JgQ=; b=IxW1IrikTZQrto9VxpxJKaArvmb0g2nUj9Zq9R+w/9bZgDahZnqFAU7rXtbfJejgwW8W 8ZrTcdAY2LRV1FX4KRIaBS/bvHPjO3sMFOTSWiQ5iz9VpdUEu4/SBaTOdsHYvVTlsbojqE EL7H9Jkhb5ab4mhiYyp4C3Qb1MNk4nyHoL0anbwCIuydTrrfvnQytHnKQ9uEPUYt48kVx4 ga39lo0dDAW2zsAEEfRh+aKL+kNqBKM1NnzlmXAxyr/kh26IS8uBP/n5uCDRI2MJizzNOc ACgGW4hwTop9LZF50YJ89l2N+TrisuSI9NHkYNiFL0JDbTSONMuPjmbeML6iCBeA== Received: by recvd-84b546689d-6cb64 with SMTP id recvd-84b546689d-6cb64-1-67626809-2 2024-12-18 06:13:29.332009144 +0000 UTC m=+2882997.899808526 Received: from herokuapp.com (unknown) by geopod-ismtpd-28 (SG) with ESMTP id st_SooZ1Sa6Cw4e6Vq9JVw for ; Wed, 18 Dec 2024 06:13:29.262 +0000 (UTC) Date: Wed, 18 Dec 2024 06:13:29 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20925 X-Redmine-Issue-Author: Dan0042 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 96967 X-SG-EID: =?us-ascii?Q?u001=2Eqca74XLbbBG2T0HhbEZgBN9E1Qhb0c7bGBe1waNAWdTreSqyWPDekZUgq?= =?us-ascii?Q?NYk4+nm=2F0VIqwc8ZBTQxqk7G=2FctsRLtYG2yTl=2FP?= =?us-ascii?Q?2CaGNETxG2Q+vjHxTmBMJiFQsMKRhfz4ByD644+?= =?us-ascii?Q?xGuxhPuhpEOP5vhB6+2IvONnbh0R55CMKZIk4mx?= =?us-ascii?Q?objmpc9H7KVTkbAaRYqA6bL34lPFdVn5zAtEArg?= =?us-ascii?Q?ZtsEvST8qr90gzL9B4wN6XQaXIa4TVFe=2Fqo=2F8q+?= =?us-ascii?Q?IyhosDuknC2hVAePSbCfI8cmWA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: PEJHL5J2LQUMYKWWHGG7DVBR4N4OP26S X-Message-ID-Hash: PEJHL5J2LQUMYKWWHGG7DVBR4N4OP26S X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120290] [Ruby master Feature#20925] Allow boolean operators at beginning of line to continue previous line List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "matz (Yukihiro Matsumoto) via ruby-core" Cc: "matz (Yukihiro Matsumoto)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20925 has been updated by matz (Yukihiro Matsumoto). +1. Although it might take time to implement since we have duplicated parser implementations at the moment. Matz. ---------------------------------------- Feature #20925: Allow boolean operators at beginning of line to continue previous line https://bugs.ruby-lang.org/issues/20925#change-111055 * Author: Dan0042 (Daniel DeLorme) * Status: Open ---------------------------------------- I would like for this to become accepted syntax: condition1 || condition2 condition1 && condition2 condition1 or condition2 condition1 and condition2 This is similar to how method chaining on the second line was added in Ruby 1.9 expr .method And it has the same advantage: when you have a multi-line expression, instead of hunting for the dot or boolean operator at the end of line1, it's right there at the beginning of line2, making the structure very obvious and readable. Please contrast: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption The first expression must rely on indentation to communicate the multi-line nature of the condition, and even then it's not as immediately obvious as the second expression, where we can see easily and immediately that this is a multi-line `&&` condition. This syntax is also similar to how a trailing comma is allowed in arrays and hashes (and method calls since Ruby 1.9), with the same advantage. It makes for a cleaner diff when you add an element to the array/hash/conditional. Taking the previous example, imagine we are adding the condition `&& request.use_authenticated_cookie_encryption`. Now contrast the diff between the two styles: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && - request.encrypted_cookie_salt.present? + request.encrypted_cookie_salt.present? && + request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? + && request.use_authenticated_cookie_encryption Based on the above I would say this syntax is natural and consistent with existing Ruby syntactical elements, and would greatly improve code readability. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/