ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "byroot (Jean Boussier) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "byroot (Jean Boussier)" <noreply@ruby-lang.org>
Subject: [ruby-core:120320] [Ruby master Bug#20968] `Array#fetch_values` unexpected method name in stack trace
Date: Thu, 19 Dec 2024 07:53:02 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-111092.20241219075302.9869@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20968.20241219054042.9869@ruby-lang.org>

Issue #20968 has been updated by byroot (Jean Boussier).


I agree with @jeremyevans0 that it's not a bug.

But if it's decided than it is, then there's no need to rewrite it all in C, you can just set the `c_trace` attribute:

```ruby
Primitive.attr! :c_trace
```

----------------------------------------
Bug #20968: `Array#fetch_values` unexpected method name in stack trace
https://bugs.ruby-lang.org/issues/20968#change-111092

* Author: koic (Koichi ITO)
* Status: Open
* ruby -v: ruby 3.4.0dev (2024-12-19T04:44:56Z master 2783868de2) +PRISM [x86_64-darwin23]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------

It seems that the current Ruby implementation is displaying unexpected method name in stack trace.

## Expected

Similar to `Hash#fetch_values`, the method name `Array#fetch_values` is expected to be displayed in the stack trace.

```console
$ ruby -e '{k: 42}.fetch_values(:unknown)'
-e:1:in 'Hash#fetch_values': key not found: :unknown (KeyError)
        from -e:1:in '<main>'

$ ruby -e '[1].fetch_values(42)'
-e:1:in 'Array#fetch_values': index 42 outside of array bounds: -1...1 (IndexError)
        from -e:1:in '<main>'
```


## Actual

The stack trace displays the `Array#fetch` method, which user is not aware of, along with the `<internal.array>` stack trace.

```console
$ ruby -e '[1].fetch_values(42)'
<internal:array>:211:in 'Array#fetch': index 42 outside of array bounds: -1...1 (IndexError)
        from <internal:array>:211:in 'block in Array#fetch_values'
        from <internal:array>:211:in 'Array#map!'
        from <internal:array>:211:in 'Array#fetch_values'
        from -e:1:in '<main>'
```


It likely requires an approach such as implementing it in C, as suggested in https://github.com/ruby/ruby/pull/11555.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2024-12-19  7:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  5:40 [ruby-core:120315] " koic (Koichi ITO) via ruby-core
2024-12-19  6:20 ` [ruby-core:120316] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-12-19  7:53 ` byroot (Jean Boussier) via ruby-core [this message]
2024-12-19  8:37 ` [ruby-core:120324] " koic (Koichi ITO) via ruby-core
2025-02-18 10:59 ` [ruby-core:121100] " Eregon (Benoit Daloze) via ruby-core
2025-02-18 18:40 ` [ruby-core:121107] " mame (Yusuke Endoh) via ruby-core
2025-02-18 23:19 ` [ruby-core:121116] " Eregon (Benoit Daloze) via ruby-core
2025-02-19  1:47 ` [ruby-core:121119] [Ruby master Misc#20968] " jeremyevans0 (Jeremy Evans) via ruby-core
2025-02-19  9:58 ` [ruby-core:121122] " Eregon (Benoit Daloze) via ruby-core
2025-03-02 22:18 ` [ruby-core:121216] " ioquatix (Samuel Williams) via ruby-core
2025-03-13 11:06 ` [ruby-core:121325] " mame (Yusuke Endoh) via ruby-core
2025-03-13 11:09 ` [ruby-core:121326] " byroot (Jean Boussier) via ruby-core
2025-03-13 12:07 ` [ruby-core:121337] " matz (Yukihiro Matsumoto) via ruby-core
2025-03-13 14:25 ` [ruby-core:121348] " Eregon (Benoit Daloze) via ruby-core
2025-03-14  7:12 ` [ruby-core:121360] [Ruby " mame (Yusuke Endoh) via ruby-core
2025-03-14  9:51 ` [ruby-core:121362] " Eregon (Benoit Daloze) via ruby-core
2025-04-08  3:22 ` [ruby-core:121569] " hsbt (Hiroshi SHIBATA) via ruby-core
2025-04-08 17:34 ` [ruby-core:121593] " Dan0042 (Daniel DeLorme) via ruby-core
2025-04-15  8:01 ` [ruby-core:121665] " akr (Akira Tanaka) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-111092.20241219075302.9869@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).