From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 318531F4CC for ; Fri, 20 Dec 2024 01:23:27 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=jxqJ5Rwj; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=S0dMQo0b; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1734657804; bh=kNOVvbvTY7ZocHwi9sF0wTExiA3OvxrKifowU1y/N+U=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=jxqJ5RwjzZV9lj8CdD6zz+WwwdBhPhLcj9HvDVf2dgq7OR+kZbsHlGNi7Hbx4hR0Q rKPdmqWONnMSVnFg1ngwP0UuGZonEunFVMQUO0WBjpwF8VCqjEHR9ip0ClNGjDT30t XjByTYuZcIrXMx8krIvMfVgvuTn4EBP/yNyGY+vg= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 97E9D44E69 for ; Fri, 20 Dec 2024 01:23:24 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=S0dMQo0b; dkim-atps=neutral Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 2850044BFD for ; Fri, 20 Dec 2024 01:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=/c9Ftt2TB5A/POEABldNH277LCdSv3kUs7wuLV344s0=; b=S0dMQo0b4HPLfWtW7jxCc5TbXWh3IhIeNcLg6LTHDtb5SI5PuIrD+dxQotdSjUP6TfyC d4rlJ6e9K+mns4SbjVKIM9hGnQuS71I5Ymr2mkWRjmhtQMLOZKOelL5km6qf/G6wIdrUEH U8gX96hYGUl7ACIuIC0KhkX90pazpiHiZeCj/bCl3uToROqimWDDMgTw44i+s8gzNEBuj5 JAZEDeooKcPd4XTq4GpstZKO7SxjYwbS9ELFm4AqXhdzXblcrn7Xdsdouds+IUPfZuvaxH uwqBJTUhTgaPdiCoA9vPdoya9/AQ2nzmnr1ZzDVeyHGTyujLL5Ff1GICv/TyLIBA== Received: by recvd-5c8ccdbd88-lns5k with SMTP id recvd-5c8ccdbd88-lns5k-1-6764C707-5 2024-12-20 01:23:19.993572298 +0000 UTC m=+3038456.163667384 Received: from herokuapp.com (unknown) by geopod-ismtpd-13 (SG) with ESMTP id 5NyRSyc7TiWxTiSaXrmDiQ for ; Fri, 20 Dec 2024 01:23:19.933 +0000 (UTC) Date: Fri, 20 Dec 2024 01:23:20 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20971 X-Redmine-Issue-Author: Earlopain X-Redmine-Issue-Priority: Normal X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97014 X-SG-EID: =?us-ascii?Q?u001=2E5PtzXJ23KrYzgM1nrOIr+EQ222PyrDaWSg0Er8CZ8tP86xyXmBM81zBKD?= =?us-ascii?Q?HreavdFYMbHjxXOR6UPMkt=2Fu9CyBIp6y52n8D2y?= =?us-ascii?Q?qA9zqurrgUeP=2FilY1EBxJJH2CbSBdFlJ9si571Q?= =?us-ascii?Q?1pZs=2FYjgEiKX8wWv=2FPD=2F=2F6XAq6JIq466AIW7bRS?= =?us-ascii?Q?ScasDzWbg68xNlSSLqv3CjyRVIqLMxVorbzk+sW?= =?us-ascii?Q?JxpbMyoS1EeM5fpdsa4jCSY5fs2DtORoOWZDehp?= =?us-ascii?Q?dGus9OjaKSFc5Cg=2FaU4OcRrO7A=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: DDBFXI5P5S3GJHKOHQXWS7XMGLNZMTR7 X-Message-ID-Hash: DDBFXI5P5S3GJHKOHQXWS7XMGLNZMTR7 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120337] [Ruby master Feature#20971] Deprecate `rb_path_check` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nobu (Nobuyoshi Nakada) via ruby-core" Cc: "nobu (Nobuyoshi Nakada)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20971 has been updated by nobu (Nobuyoshi Nakada). I think that `rb_path_check` is a separate thing from "object taintedness", and that the removal of `path_tainted_p` in `env_aset` in despite of it is in `!OBJ_TAINTED` side was unintentionally. @jeremyevans0 What do you think? ---------------------------------------- Feature #20971: Deprecate `rb_path_check` https://bugs.ruby-lang.org/issues/20971#change-111110 * Author: Earlopain (Earlopain _) * Status: Open ---------------------------------------- With #16131, various code around $SAFE, taint, etc. has been deprecated and removed. GH PR https://github.com/ruby/ruby/pull/2476. Now, [`rb_path_check`] still exists as part of the public API, with Ruby itself never using or testing it. I believe it should have been deprecated and was simply missed. Should it be deprecated today or is that not worth the effort? Docs for it are pretty vague: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/include/ruby/internal/intern/hash.h#L289-L297 > This function is mysterious. What it does is not immediately obvious. Also what it does seems platform dependent. [`rb_path_check`]: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/file.c#L6427 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/