From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F26911F4CC for ; Fri, 20 Dec 2024 01:58:27 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=mFFDupYZ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ngj+46/X; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1734659874; bh=RfmdCiLQO/tNGr1MsF4dEciSJGmMpP07bJ8sLDfcOEs=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=mFFDupYZNBD3etDbMF3sLC6v9lpNCsYZX+lM7hHhKq9hAq5Kg4NPx0eOm3g/RDXPs aTsl9RNtl/KGjOccY44HQQS/8d5EldBX1847YNdiIV/osAlNLOpelpEXvyrLn7AIEo yoHJtuIb0hL5Z5H+NuDScZiPGLBTIg61PmYt/bKk= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 96B09452F8 for ; Fri, 20 Dec 2024 01:57:54 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=Ngj+46/X; dkim-atps=neutral Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 379D444E69 for ; Fri, 20 Dec 2024 01:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=v3pGHcOyQ1S0rgomWByUgBB8O72kYHyZAjwd+7RBsZA=; b=Ngj+46/XrTUsejOA7blWjCzMphl2VWUOA+nG7/kzfQMnhjdzZWpGnegDohhb/U7FVDs6 gIzpVipnRXt0hJIhFSI/CSG9AFeGizwWEkCqRMYwehATI7rzl7eb2n2tb4my/vrhhw57Gz 2LMdda5OeznoCcLdlh+WrKGzRto41k/EQg+GMouRi6bPiQWwLp+Ern/ezKQU1/mR1ouKH5 oF6960m3gRY+pYrTEyWDoPzjfJyAX/ky7LRx6W0ZLa+aAXnxfHZmi4PVR3o75a8sryezj9 B98NBmKy173TJzuWbgMck43DxfBzTD+NDMlYco5qKeciP+AAtbP62QxCDC0w+2ZA== Received: by recvd-5c8ccdbd88-zc62f with SMTP id recvd-5c8ccdbd88-zc62f-1-6764CF1D-5 2024-12-20 01:57:49.271017237 +0000 UTC m=+3040498.263839050 Received: from herokuapp.com (unknown) by geopod-ismtpd-31 (SG) with ESMTP id HWhFLiKURFenjyrYaXeWDQ for ; Fri, 20 Dec 2024 01:57:49.228 +0000 (UTC) Date: Fri, 20 Dec 2024 01:57:49 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20971 X-Redmine-Issue-Author: Earlopain X-Redmine-Issue-Priority: Normal X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97015 X-SG-EID: =?us-ascii?Q?u001=2ELyyp8a6L4BPdoBZ5kcNQuEdalXgUnCKLcPykf2c9d2sTWfvALBzqM4Ij+?= =?us-ascii?Q?Jg9Prp2eVDkf9lIZhzc05KfUT4Npfgnigb95d+v?= =?us-ascii?Q?hGuAMoCQYcIoZWlR8JQY7qE7=2FJpUloIgEq2zfRT?= =?us-ascii?Q?se+brmWpat8A0w6gnQ9zR=2FfpPLgKM6am5KTW9XB?= =?us-ascii?Q?hHXVVD4P4xOeAevXB6Kx=2F0cmCz02IS8x0u1gdfv?= =?us-ascii?Q?suVNPnpmZxtwZd5rBI+xdvN=2Fu8aLSlAnKnugjQR?= =?us-ascii?Q?5T9sIys5zXOE2AjYGSxmt=2FWEzQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: NYQFKIIOYAO5FEIBGKRSKMSTSNYBGHNM X-Message-ID-Hash: NYQFKIIOYAO5FEIBGKRSKMSTSNYBGHNM X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120338] [Ruby master Feature#20971] Deprecate `rb_path_check` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "jeremyevans0 (Jeremy Evans) via ruby-core" Cc: "jeremyevans0 (Jeremy Evans)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20971 has been updated by jeremyevans0 (Jeremy Evans). >>From looking at the history, `rb_path_check` was originally used by `rb_env path_tainted`, presumably to check whether the PATH environment variable was tainted, so as not to trust it. That may be why it is in the hash.h header instead of the file.h header, even though it makes no sense in the hash.h header. `rb_path_check` was used in MJIT, to check for unsafe header files, but that was the last usage I could see in CRuby. I'm guessing that is a reason it may not have been deprecated/removed when $SAFE/taint was deprecated/removed. If we can do a gem codesearch for `rb_path_check`, and nothing important comes up, I am in favor of deprecating and then removing it. I looked through the first 5 pages of GitHub results and nothing of note came up, other than the fact that TruffleRuby does not implement the function. ---------------------------------------- Feature #20971: Deprecate `rb_path_check` https://bugs.ruby-lang.org/issues/20971#change-111111 * Author: Earlopain (Earlopain _) * Status: Open ---------------------------------------- With #16131, various code around $SAFE, taint, etc. has been deprecated and removed. GH PR https://github.com/ruby/ruby/pull/2476. Now, [`rb_path_check`] still exists as part of the public API, with Ruby itself never using or testing it. I believe it should have been deprecated and was simply missed. Should it be deprecated today or is that not worth the effort? Docs for it are pretty vague: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/include/ruby/internal/intern/hash.h#L289-L297 > This function is mysterious. What it does is not immediately obvious. Also what it does seems platform dependent. [`rb_path_check`]: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/file.c#L6427 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/