From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 836BC1F4CC for ; Sat, 21 Dec 2024 21:04:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=2AtUDzrL; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=TacHgtn/; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1734815057; bh=diVCnmscQZCdSm29SK1v2BL+gNbxOw/EgaCr9RN5o3Y=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=2AtUDzrLiSaI7XQS4KtZ7BfVQLH4k0IPr8q4JGCQH6dda1lu83Zq7PMLYLrDxl5Ij JKA767GoDKZKzslNjsh0AwJ7jXtcw87MwYNsz8yCfLnnXWIG0Fre4lFfbT3kqKJTqs tr1nxWdb576uQYr1LWRHJGGwrBdhe6taoor01EEA= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id D537E45F3B for ; Sat, 21 Dec 2024 21:04:17 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=TacHgtn/; dkim-atps=neutral Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 861DC44CA9 for ; Sat, 21 Dec 2024 21:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=kUEX9qjsthB67YEh2NHpSkq4JhPyH1UXkxMNBUmDGk8=; b=TacHgtn/rfxnRi8NDbdlHlD6s7N8q5JiGI0HlJoi6enwCPJlHzBDEH0Dye3zCjXuqB8i fUcwsJx2gJDdNSch2PRGDxcK8MJAxkJ/AZWQl4APlg1Z63LHcEgiBBOuXtkwOUMCFWLEpa eWw/NeLK+qlKDWReMcivtgqq1TSEHegsIWXxFvjJ65C4kwNS7SAGnsl6uFr5jY2xgaOmUX /QykQKuGJa2kHr3foXiVP17PArt6HisMngmNduIZtlFuYA/vrXJ/5LlprMUEADIv6yqEyF hbaR2Cg4eq+kp7Zv63ChehfzQFquHAvd8AycBBm1RWSTBf3yAyIhw4aZt3ZH7AJQ== Received: by recvd-84b546689d-lhvdm with SMTP id recvd-84b546689d-lhvdm-1-67672D47-22 2024-12-21 21:04:07.831108457 +0000 UTC m=+3195770.300617335 Received: from herokuapp.com (unknown) by geopod-ismtpd-19 (SG) with ESMTP id geLHd54KQ6OtqeiMyT4Arg for ; Sat, 21 Dec 2024 21:04:07.773 +0000 (UTC) Date: Sat, 21 Dec 2024 21:04:10 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20925 X-Redmine-Issue-Author: Dan0042 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: kddnewton X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97034 X-SG-EID: =?us-ascii?Q?u001=2E41nWPij=2FD1kdGmpgWeHScbb9X8tZePZrQQx3bl8Vy2odBuMhLMhId2kIq?= =?us-ascii?Q?I4MmMJ43lNHfKPNNds=2Fb3JsTYpYoWyQb3+sPV4d?= =?us-ascii?Q?vscaSKwkBzUIGq7SdX2xhIVKqL0iXNZVl=2FTFH+B?= =?us-ascii?Q?sovZPHzNutT7k9kHtGhEoZ5TdKX8FnYfuODS9k1?= =?us-ascii?Q?vHf6i8NapZy3PumAndq0zrwUqjsN3F9MHG99U86?= =?us-ascii?Q?CpCHghaAvpk7Y=2FF94yxfM2M38T3eoHJCpAmPoCX?= =?us-ascii?Q?rf7jCZAKyNmwSRaFeuw3bhwLfA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: QLQTHWTEPVP5NLOAQYDCAFHVNMFON3QY X-Message-ID-Hash: QLQTHWTEPVP5NLOAQYDCAFHVNMFON3QY X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120357] [Ruby master Feature#20925] Allow boolean operators at beginning of line to continue previous line List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "kddnewton (Kevin Newton) via ruby-core" Cc: "kddnewton (Kevin Newton)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20925 has been updated by kddnewton (Kevin Newton). This PR is for Prism support: https://github.com/ruby/prism/pull/3337. I will add some CRuby tests that we can skip on parse.y for now in a follow-up PR. ---------------------------------------- Feature #20925: Allow boolean operators at beginning of line to continue previous line https://bugs.ruby-lang.org/issues/20925#change-111136 * Author: Dan0042 (Daniel DeLorme) * Status: Open ---------------------------------------- I would like for this to become accepted syntax: condition1 || condition2 condition1 && condition2 condition1 or condition2 condition1 and condition2 This is similar to how method chaining on the second line was added in Ruby 1.9 expr .method And it has the same advantage: when you have a multi-line expression, instead of hunting for the dot or boolean operator at the end of line1, it's right there at the beginning of line2, making the structure very obvious and readable. Please contrast: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption The first expression must rely on indentation to communicate the multi-line nature of the condition, and even then it's not as immediately obvious as the second expression, where we can see easily and immediately that this is a multi-line `&&` condition. This syntax is also similar to how a trailing comma is allowed in arrays and hashes (and method calls since Ruby 1.9), with the same advantage. It makes for a cleaner diff when you add an element to the array/hash/conditional. Taking the previous example, imagine we are adding the condition `&& request.use_authenticated_cookie_encryption`. Now contrast the diff between the two styles: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && - request.encrypted_cookie_salt.present? + request.encrypted_cookie_salt.present? && + request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? + && request.use_authenticated_cookie_encryption Based on the above I would say this syntax is natural and consistent with existing Ruby syntactical elements, and would greatly improve code readability. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/