From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 906151F4CC for ; Mon, 23 Dec 2024 05:55:04 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=ElFijdXb; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=dhpotPEb; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1734933272; bh=6guFAZLRlM3mtCC8HJCOvPhcMvN8hk8u+6TKEj6MG9k=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=ElFijdXbDJlZXz+wWmOJ5+ihG5zaF65gf7OHjuNvjxzDu1PVd+yBj9jOnm0JTnKvd Ic0wBbHqej0OuJsaG2cFNkSUtmNGbR4XtLSjBf2qPscEDkYkDXEgePH1J9hzkiRBbD cAZxvEgoG6Cc93G74rJMYTw72YwsM1+GqrMlsQFo= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 075A945F7F for ; Mon, 23 Dec 2024 05:54:32 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=dhpotPEb; dkim-atps=neutral Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) by nue.mailmanlists.eu (Postfix) with ESMTPS id B6EA245F69 for ; Mon, 23 Dec 2024 05:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=Fy+jnHQzuiV7QFrhqaWkXV8SJ7JQuB53Iksb0FMU/Ls=; b=dhpotPEbIkWNTlyc5ni/vZ/XaobRF6H9WXpK6nGvxaDvvMaPIVkX4LwO1E4+rSrtqMRB 3b6DDSEVoPy5bDsUUmNSeL4NyfK3p4N/Ousxe7qUqMmJg7HFaMWqJIGVxp9W8O7dAELE4F mFr1N81rjPLfriFzIRBT4tLVzwCW4jFCG11MTrBau9Pv6mXf02XuDvU3WWw2c/7Ojdnh/4 XnOtsDdgN73YkoSpMtnrnk3xOx1vgkWHvXUG4GIndPlzRgf4Lpu7qUqJVLQwjI/4577MjL 9NQB1h3i0ak+d7Bv8g+WAQFh6Mzu70EcT3ZieCdM0J0xM0MuslIucHgV55qDT8JQ== Received: by recvd-5f9ffdf494-29sch with SMTP id recvd-5f9ffdf494-29sch-1-6768FB11-9 2024-12-23 05:54:25.399492244 +0000 UTC m=+3314200.106533102 Received: from herokuapp.com (unknown) by geopod-ismtpd-26 (SG) with ESMTP id K4xijR7VRkGHyofXmG9nuw for ; Mon, 23 Dec 2024 05:54:25.361 +0000 (UTC) Date: Mon, 23 Dec 2024 05:54:25 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20925 X-Redmine-Issue-Author: Dan0042 X-Redmine-Issue-Priority: Normal X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97050 X-SG-EID: =?us-ascii?Q?u001=2E5PtzXJ23KrYzgM1nrOIr+EQ222PyrDaWSg0Er8CZ8tP86xyXmBM81zBKD?= =?us-ascii?Q?HreavdFYMbHjxXOR6UPMkt=2Fu9CyBIp6y52n8D2y?= =?us-ascii?Q?qA9zqurrgUfqtrz8TpZdwtClLAfIhOt0JjmZ6ND?= =?us-ascii?Q?GW3Gi52Qmcg3RUbT3u2z2Q7jUhur7AxfDgQEykU?= =?us-ascii?Q?NIG2RuR8aN+aqOFPfsjy6eEs88u4gx7WcMw6IoY?= =?us-ascii?Q?CgdqLMbJ5XRxVSGYjOpAsRsuXkdoQ0uFkGJtEtU?= =?us-ascii?Q?A2uRRVW+0MeSNcmursY+UPGHkQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: RALJHA3CUSCG2BRMXWEOCXE6SUSH5UOG X-Message-ID-Hash: RALJHA3CUSCG2BRMXWEOCXE6SUSH5UOG X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120373] [Ruby master Feature#20925] Allow boolean operators at beginning of line to continue previous line List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "nobu (Nobuyoshi Nakada) via ruby-core" Cc: "nobu (Nobuyoshi Nakada)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20925 has been updated by nobu (Nobuyoshi Nakada). `&&` and `||` are questionable for me because they can change RHS of assignment. https://github.com/nobu/ruby/tree/leading-logical ---------------------------------------- Feature #20925: Allow boolean operators at beginning of line to continue previous line https://bugs.ruby-lang.org/issues/20925#change-111150 * Author: Dan0042 (Daniel DeLorme) * Status: Open ---------------------------------------- I would like for this to become accepted syntax: condition1 || condition2 condition1 && condition2 condition1 or condition2 condition1 and condition2 This is similar to how method chaining on the second line was added in Ruby 1.9 expr .method And it has the same advantage: when you have a multi-line expression, instead of hunting for the dot or boolean operator at the end of line1, it's right there at the beginning of line2, making the structure very obvious and readable. Please contrast: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? && request.use_authenticated_cookie_encryption The first expression must rely on indentation to communicate the multi-line nature of the condition, and even then it's not as immediately obvious as the second expression, where we can see easily and immediately that this is a multi-line `&&` condition. This syntax is also similar to how a trailing comma is allowed in arrays and hashes (and method calls since Ruby 1.9), with the same advantage. It makes for a cleaner diff when you add an element to the array/hash/conditional. Taking the previous example, imagine we are adding the condition `&& request.use_authenticated_cookie_encryption`. Now contrast the diff between the two styles: request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && - request.encrypted_cookie_salt.present? + request.encrypted_cookie_salt.present? && + request.use_authenticated_cookie_encryption request.secret_key_base.present? && request.encrypted_signed_cookie_salt.present? && request.encrypted_cookie_salt.present? + && request.use_authenticated_cookie_encryption Based on the above I would say this syntax is natural and consistent with existing Ruby syntactical elements, and would greatly improve code readability. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/