From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B0FD81F4CC for ; Tue, 24 Dec 2024 20:16:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=2CpI2nRr; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=KA/BrF8m; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1735071374; bh=tbNKQG1KXLcWmKow57OVKT82okVvb5ksCDX7P9Bz3cc=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=2CpI2nRrQAjHxz+Y4vNOyxaw0YzWigDF/+x5i83y7+3FPXh3h3e0EWtgud8BpyHeC STp7wNoy5kNdVvsZH/4P2nsGYiFDcA61U1FGh10jlttjLgHc3x54tJ7fdq9NFRq0YS /Xu6ip6JZ6Y5LCIg6oM9oNbdBdcLv4QJ1ThB4u6U= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id E16CC45F6F for ; Tue, 24 Dec 2024 20:16:14 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=KA/BrF8m; dkim-atps=neutral Received: from s.wrqvtvvn.outbound-mail.sendgrid.net (s.wrqvtvvn.outbound-mail.sendgrid.net [149.72.120.130]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 8A5AF45F66 for ; Tue, 24 Dec 2024 20:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=SKIqwST8OEZDQ1063/68opXbpj5+tSuIvI9qDsMRwmI=; b=KA/BrF8mkfKZSuU6WwnYYpqFsdpAXJqBFozSiOV7FdqgC8SHRVqJOmJejBki+X/Dg0OZ YmkNvXwvuCJDy1v0K6oCAFV0RkchMfvlJwUitT3PYEFffssCNVSKlKjiJhrxcC0ULXdHLS 3VW0W6WazfjbFLz8RFX0A+s/VHijwGSGEoHI+kmTdFMV7BoBWyd1Q/Q5j+deRWuoHqvikZ QKK3201vMnr6Wzr127wRGBoCfUbe6apcZ4jHAT3uZi0Q5kpH5/rLnLxoT2sbbJbRfJ6URq 9LKknQIgsHxz5RdS4CnhB8rowcKv1K3lxkf3JJ/nnaY7RjR5jtFhRt/9jRQ8g55w== Received: by recvd-84b546689d-997dv with SMTP id recvd-84b546689d-997dv-1-676B1688-14 2024-12-24 20:16:08.47159175 +0000 UTC m=+3452029.936927193 Received: from herokuapp.com (unknown) by geopod-ismtpd-14 (SG) with ESMTP id jhJ3mB6xSrGQrOiA_jPtDg for ; Tue, 24 Dec 2024 20:16:08.410 +0000 (UTC) Date: Tue, 24 Dec 2024 20:16:08 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20943 X-Redmine-Issue-Author: nobu X-Redmine-Issue-Priority: Normal X-Redmine-Sender: luke-gru X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97077 X-SG-EID: =?us-ascii?Q?u001=2Eu2jV1cZCX3JeC9XuCMpKrPL8QYex4qqdacL0+MyIJYZ8T98+Yamf0oq9z?= =?us-ascii?Q?aSwYa9OgKS1yrZArj33QXc1KJqA8PopG+kgVPq9?= =?us-ascii?Q?cjRbGB5G3hdDz454GxDB+LbWzTIrDV=2FmHpU6pRW?= =?us-ascii?Q?0+H8xdPqqkeQN=2Fyky3+=2FWVnjLPCgJ58lSoahaUV?= =?us-ascii?Q?gsnk34LfnhZKX5WcqoU0mUl5ElrSFY5ehNGBMAs?= =?us-ascii?Q?uS=2FWicsDVhLGlU96OtfqumgCl8mf9CmypquAf99?= =?us-ascii?Q?CfJCjJNdS+=2FytUIlszmQyx9ILA=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: AMXNPIZVCUXZE5MWEIHITRWYLDAF5CPR X-Message-ID-Hash: AMXNPIZVCUXZE5MWEIHITRWYLDAF5CPR X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:120400] [Ruby master Bug#20943] Constant defined in `Data.define` block List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "luke-gru (Luke Gruber) via ruby-core" Cc: "luke-gru (Luke Gruber)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20943 has been updated by luke-gru (Luke Gruber). You can always do this, of course: ```ruby Measure = Data.define(:amount, :unit); class Measure NONE = Data.define end ``` And I agree that `class Something = Struct.new(:a, :b)` would be nice to avoid having to do this. ---------------------------------------- Bug #20943: Constant defined in `Data.define` block https://bugs.ruby-lang.org/issues/20943#change-111180 * Author: nobu (Nobuyoshi Nakada) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- >>From https://github.com/ruby/ruby/pull/12274: > A couple times in code review I've seen constants inadvertently leak to top level from within a `Struct` or `Data` do block. I think it would be nice to show reopening the `Data` class when a constant is defined, so the constant is defined within the namespace. In this case, `Measure::NONE` instead of top level `Object::NONE`. It would also show readers that it's okay to reopen a `Data` class, which seems nice since some folk might not realize. Thanks for considering! However, I think that `NONE` probably might be intended to be defined under `Measure`. Current: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define end p NONE #=> NONE ``` Another: ```ruby Measure = Data.define(:amount, :unit) do NONE = Data.define p NONE #=> Measure::NONE end p NONE # uninitialized constant NONE (NameError) ``` @zverok How do think? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/