ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "tenderlovemaking (Aaron Patterson) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "tenderlovemaking (Aaron Patterson)" <noreply@ruby-lang.org>
Subject: [ruby-core:120539] [Ruby master Bug#21014] Prism doesn't set node_id on iseqs correctly
Date: Wed, 08 Jan 2025 00:36:16 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-111340.20250108003616.73@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-21014.20250108003503.73@ruby-lang.org>

Issue #21014 has been updated by tenderlovemaking (Aaron Patterson).


Fix sent here: https://github.com/ruby/ruby/pull/12527

----------------------------------------
Bug #21014: Prism doesn't set node_id on iseqs correctly
https://bugs.ruby-lang.org/issues/21014#change-111340

* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
* Assignee: prism
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
Given this code:

```ruby
f = proc { <<END }
  heredoc
END

iseq = RubyVM::InstructionSequence.of(f)
p iseq.to_a[4][:node_id]
```

Output on parse.y:

```
$ ./miniruby --parser=parse.y test.rb
3
```

Output on Prism:

```
$ ./miniruby test.rb
-1
```

I don't expect node IDs on Prism to match parse.y, but I do expect the node id to be a legitimate node id.  For example, this program should work:

```ruby
f = proc { <<END }
  heredoc
END

iseq = RubyVM::InstructionSequence.of(f)

require "prism"

node_id = iseq.to_a[4][:node_id]

ast = Prism.parse(File.binread(__FILE__))
p ast.value.breadth_first_search { |node| node.node_id == node_id }
```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

      reply	other threads:[~2025-01-08  0:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  0:35 [ruby-core:120538] " tenderlovemaking (Aaron Patterson) via ruby-core
2025-01-08  0:36 ` tenderlovemaking (Aaron Patterson) via ruby-core [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-111340.20250108003616.73@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).