[ruby-core:120577] [Ruby master Feature#8751] Add offsets to method#source_location

[ruby-core:120577] [Ruby master Feature#8751] Add offsets to method#source_location

[Eregon (Benoit Daloze) via ruby-core]

Issue #8751 has been updated by Eregon (Benoit Daloze).


In light of end line and column information being added in #6012 do you think there is still a need for byte offsets?

----------------------------------------
Feature #8751: Add offsets to method#source_location
https://bugs.ruby-lang.org/issues/8751#change-111404

* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
----------------------------------------
Hello,

I would like to have byte offsets returned on the source_location for methods.  For example:

def foo(&b)
  b.source_location # => [file_name, line_number, start_byte, end_byte]
end

If we had the start and end byte for a method or proc, then we could find the source for methods and procs in each file.  There are some cases (like with heredocuments) where the "end of the method" could be after the `end` keyword.  But I think if we just have offsets for the start of `def` and the end of `end`, I think it would cover 99% of usecases.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120589] [Ruby master Feature#8751] Add offsets to method#source_location

[rocky (Rocky Bernstein) via ruby-core]

Issue #8751 has been updated by rocky (Rocky Bernstein).


Eregon (Benoit Daloze) wrote in #note-7:
> In light of end line and column information being added in #6012 do you think there is still a need for byte offsets?

Sure, this is fine. Feel free to close issue.

----------------------------------------
Feature #8751: Add offsets to method#source_location
https://bugs.ruby-lang.org/issues/8751#change-111414

* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
----------------------------------------
Hello,

I would like to have byte offsets returned on the source_location for methods.  For example:

def foo(&b)
  b.source_location # => [file_name, line_number, start_byte, end_byte]
end

If we had the start and end byte for a method or proc, then we could find the source for methods and procs in each file.  There are some cases (like with heredocuments) where the "end of the method" could be after the `end` keyword.  But I think if we just have offsets for the start of `def` and the end of `end`, I think it would cover 99% of usecases.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/