[ruby-core:120579] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[ruby-core:120579] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[ksss (Yuki Kurihara) via ruby-core]

Issue #21020 has been reported by ksss (Yuki Kurihara).

----------------------------------------
Feature #21020: Sync sig directory for prism of default gem.
https://bugs.ruby-lang.org/issues/21020

* Author: ksss (Yuki Kurihara)
* Status: Open
----------------------------------------
Currently, the type signatures (RBS) for the default gem is not available.
**Prism** is the only default gem with type signatures, but this number is expected to increase in the future.

As a first step to resolving this issue, I propose including the `sig` directory of Prism as a default gem in the synchronization process.

PR: https://github.com/ruby/ruby/pull/12541



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120616] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[kddnewton (Kevin Newton) via ruby-core]

Issue #21020 has been updated by kddnewton (Kevin Newton).


I'm fine with this if everyone else is.

----------------------------------------
Feature #21020: Sync sig directory for prism of default gem.
https://bugs.ruby-lang.org/issues/21020#change-111447

* Author: ksss (Yuki Kurihara)
* Status: Open
----------------------------------------
Currently, the type signatures (RBS) for the default gem is not available.
**Prism** is the only default gem with type signatures, but this number is expected to increase in the future.

As a first step to resolving this issue, I propose including the `sig` directory of Prism as a default gem in the synchronization process.

PR: https://github.com/ruby/ruby/pull/12541



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120976] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[hsbt (Hiroshi SHIBATA) via ruby-core]

Issue #21020 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Assigned
Assignee set to prism

I'm interesting that location of signature with fresh installation of ruby.

The sig directory under the `prism` is fine if we have only prism signature. Where is the best location if we will add `json` or `psych` signatures?

```
1. $prefix/lib/ruby/3.5.0+0/$name/sig <- current proposal
2. $prefix/lib/ruby/3.5.0+0/sig/$name
3. $prefix/lib/ruby/sig/$name
4. $prefix/lib/ruby/gems/3.5.0+0/sig/$name
5. $GEM_HOME/sig/$name # This is same as 4 with $GEM_HOME is not specified.
6. $prefix/include/sig/$name
7. $prefix/share/sig/$name
...
```

I prefer 2 or 3. 

----------------------------------------
Feature #21020: Sync sig directory for prism of default gem.
https://bugs.ruby-lang.org/issues/21020#change-111877

* Author: ksss (Yuki Kurihara)
* Status: Assigned
* Assignee: prism
----------------------------------------
Currently, the type signatures (RBS) for the default gem is not available.
**Prism** is the only default gem with type signatures, but this number is expected to increase in the future.

As a first step to resolving this issue, I propose including the `sig` directory of Prism as a default gem in the synchronization process.

PR: https://github.com/ruby/ruby/pull/12541



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120978] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[Eregon (Benoit Daloze) via ruby-core]

Issue #21020 has been updated by Eregon (Benoit Daloze).


How about `$prefix/lib/ruby/gems/3.5.0+0/gems/$name-$version/sig` so it would be consistent between default and bundled gems?

----------------------------------------
Feature #21020: Sync sig directory for prism of default gem.
https://bugs.ruby-lang.org/issues/21020#change-111881

* Author: ksss (Yuki Kurihara)
* Status: Assigned
* Assignee: prism
----------------------------------------
Currently, the type signatures (RBS) for the default gem is not available.
**Prism** is the only default gem with type signatures, but this number is expected to increase in the future.

As a first step to resolving this issue, I propose including the `sig` directory of Prism as a default gem in the synchronization process.

PR: https://github.com/ruby/ruby/pull/12541



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120990] [Ruby master Feature#21020] Sync sig directory for prism of default gem.

[kddnewton (Kevin Newton) via ruby-core]

Issue #21020 has been updated by kddnewton (Kevin Newton).


I think the code in the PR is good, but I agree I don't think the sig should live under `prism/sig`. I think it should be top directory of ruby repository `sig`. When it's installed I agree with @Eregon but I also think @hsbt's solution 2 is fine, provided RBS knows to use the overridden version if one is provided.

----------------------------------------
Feature #21020: Sync sig directory for prism of default gem.
https://bugs.ruby-lang.org/issues/21020#change-111894

* Author: ksss (Yuki Kurihara)
* Status: Assigned
* Assignee: prism
----------------------------------------
Currently, the type signatures (RBS) for the default gem is not available.
**Prism** is the only default gem with type signatures, but this number is expected to increase in the future.

As a first step to resolving this issue, I propose including the `sig` directory of Prism as a default gem in the synchronization process.

PR: https://github.com/ruby/ruby/pull/12541



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/