From: "k0kubun (Takashi Kokubun) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "k0kubun (Takashi Kokubun)" <noreply@ruby-lang.org>
Subject: [ruby-core:120680] [Ruby master Bug#20892] `ObjectSpace.dump` can produce broken JSON for classes with temporary names
Date: Wed, 15 Jan 2025 01:46:40 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-111503.20250115014640.7941@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-20892.20241112184736.7941@ruby-lang.org>
Issue #20892 has been updated by k0kubun (Takashi Kokubun).
Backport changed from 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE
`ruby_3_3` merged https://github.com/ruby/ruby/pull/12068. Thank you!
----------------------------------------
Bug #20892: `ObjectSpace.dump` can produce broken JSON for classes with temporary names
https://bugs.ruby-lang.org/issues/20892#change-111503
* Author: byroot (Jean Boussier)
* Status: Closed
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE
----------------------------------------
```ruby
puts ObjectSpace.dump(Class.new.tap { |c| c.set_temporary_name('" little boby table') })
```
Produces the following JSON:
```json
{
"address":"0x120bea980",
"type":"CLASS",
"shape_id":2,
"slot_size":160,
"class":"0x120bea840",
"variation_count":0,
"superclass":"0x1041ffd38",
"name":"" little boby table",
"references":["0x1041ffd38", "0x123e71a98"],
"memsize":192,
"flags":{"wb_protected":true}
}
```
Notice how the `name` property is broken.
This only impacts 3.3.x, as that's when `set_temporary_name` was introduced, before that, it was impossible to assign a name that would cause such bug.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2025-01-15 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 18:47 [ruby-core:119903] " byroot (Jean Boussier) via ruby-core
2025-01-15 1:46 ` k0kubun (Takashi Kokubun) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-111503.20250115014640.7941@ruby-lang.org \
--to=ruby-core@ml.ruby-lang.org \
--cc=noreply@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).