[ruby-core:120795] [Ruby master Bug#21090] SEGV from require in Thread in Ractor

[ruby-core:120795] [Ruby master Bug#21090] SEGV from require in Thread in Ractor

[wanabe (_ wanabe) via ruby-core]

Issue #21090 has been reported by wanabe (_ wanabe).

----------------------------------------
Bug #21090: SEGV from require in Thread in Ractor
https://bugs.ruby-lang.org/issues/21090

* Author: wanabe (_ wanabe)
* Status: Open
* ruby -v: ruby 3.5.0dev (2025-01-18T00:19:17Z origin/master 65a7c69188) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
When ruby calls 'require' in Thread in non-main Ractor, it can cause SEGV sometimes.

```
$ ruby -e '1000.times { Ractor.new { th = Thread.new { require "rbconfig" }; Thread.pass }.take }' > segv.log 2>&1
Segmentation fault (core dumped)
```

`segv.log` is too large to paste in this description, so I attached as a file.

---Files--------------------------------
segv.log (36.9 KB)


-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120803] [Ruby master Bug#21090] SEGV from require in Thread in Ractor

[luke-gru (Luke Gruber) via ruby-core]

Issue #21090 has been updated by luke-gru (Luke Gruber).


I couldn't track down the exact cause of the issue, but I do have a PR coming that solves it.

----------------------------------------
Bug #21090: SEGV from require in Thread in Ractor
https://bugs.ruby-lang.org/issues/21090#change-111670

* Author: wanabe (_ wanabe)
* Status: Open
* ruby -v: ruby 3.5.0dev (2025-01-18T00:19:17Z origin/master 65a7c69188) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
When ruby calls 'require' in Thread in non-main Ractor, it can cause SEGV sometimes.

```
$ ruby -e '1000.times { Ractor.new { th = Thread.new { require "rbconfig" }; Thread.pass }.take }' > segv.log 2>&1
Segmentation fault (core dumped)
```

`segv.log` is too large to paste in this description, so I attached as a file.

---Files--------------------------------
segv.log (36.9 KB)


-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:120866] [Ruby master Bug#21090] SEGV from require in Thread in Ractor

[luke-gru (Luke Gruber) via ruby-core]

Issue #21090 has been updated by luke-gru (Luke Gruber).


I managed to track down the issues, as there were more than 1.

I'll copy my PR message below:


stack struct memory was receiving weird values with lots of ractors when
calling Ractor#require in a thread that wasn't joined.
This was due to the script exiting before the ractor channel yields to the taker.
In that case, the taker can receive a FATAL interrupt and jump to its end, but
the channel might still try to use that stack object from the taker when its thread
starts. For this reason, we allocate on the heap and free after the require ends.

There were 2 more issues as well:

We must close the incoming port of the taker before raising, or another
ractor might try to yield to us. This would use the basket object on the
stack of the taker, but it will be corrupted after a raise.

There was an issue with ractor barriers during GC, any thread calling
ractor_sched_barrier_join_wait_locked must not lock TH_SCHED(th) of
calling thread. Otherwise this could result in a deadlock if another
thread tries to lock our sched.

----------------------------------------
Bug #21090: SEGV from require in Thread in Ractor
https://bugs.ruby-lang.org/issues/21090#change-111740

* Author: wanabe (_ wanabe)
* Status: Open
* ruby -v: ruby 3.5.0dev (2025-01-18T00:19:17Z origin/master 65a7c69188) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
When ruby calls 'require' in Thread in non-main Ractor, it can cause SEGV sometimes.

```
$ ruby -e '1000.times { Ractor.new { th = Thread.new { require "rbconfig" }; Thread.pass }.take }' > segv.log 2>&1
Segmentation fault (core dumped)
```

`segv.log` is too large to paste in this description, so I attached as a file.

---Files--------------------------------
segv.log (36.9 KB)


-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/