ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "osyoyu (Daisuke Aritomo) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "osyoyu (Daisuke Aritomo)" <noreply@ruby-lang.org>
Subject: [ruby-core:120860] [Ruby master Bug#21108] C-c (SIGINT) crashes ruby when looping Ractors are not taken?
Date: Sun, 02 Feb 2025 10:22:41 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-111734.20250202102240.10855@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-21108.20250202085928.10855@ruby-lang.org>

Issue #21108 has been updated by osyoyu (Daisuke Aritomo).


Created a patch: https://github.com/ruby/ruby/pull/12689

----------------------------------------
Bug #21108: C-c (SIGINT) crashes ruby when looping Ractors are not taken?
https://bugs.ruby-lang.org/issues/21108#change-111734

* Author: osyoyu (Daisuke Aritomo)
* Status: Open
* ruby -v: ruby 3.5.0dev (2025-01-27T08:19:32Z master c3c7300b89) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
Hitting C-c causes ruby to crash under these circumstances.

## Repro

Hit C-c while the program is running.

```ruby
r1 = Ractor.new do
  ary = []
  loop do
    Ractor.receive
    Ractor.yield ary.push(1)
  end
end

r2 = Ractor.new(r1) do |r1|
  loop do |i|
    r1.send(nil)
    r1.take
  end
end

# r1.take # `take`ing r1 will fix this issue
r2.take
```

### Expected

The process quits.

### Actual

An `[BUG] unreachable` occurs.

The rb_bug() is called inside `ractor_try_yield`.
https://github.com/ruby/ruby/blob/ace39a3ed40cc32ff8d48893173413a7e05b8316/ractor.c#L1359

```
wrap.rb:1: warning: Ractor is experimental, and the behavior may change in future versions of Ruby! Also there are many implementation issues.
<internal:ractor>:644: [BUG] unreachable
ruby 3.5.0dev (2025-01-27T08:19:32Z master c3c7300b89) +PRISM [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0005 p:0003 s:0022 e:000021 METHOD <internal:ractor>:644
c:0004 p:0014 s:0015 e:000014 BLOCK  wrap.rb:5
c:0003 p:0017 s:0012 e:000011 METHOD <internal:kernel>:168
c:0002 p:0008 s:0007 e:000006 BLOCK  wrap.rb:3 [FINISH]
c:0001 p:---- s:0003 e:000002 DUMMY  [FINISH]

-- Ruby level backtrace information ----------------------------------------
wrap.rb:3:in 'block in <main>'
<internal:kernel>:168:in 'loop'
wrap.rb:5:in 'block (2 levels) in <main>'
<internal:ractor>:644:in 'yield'

-- Threading information ---------------------------------------------------
Total ractor count: 2
Ruby thread count for this ractor: 1

-- C level backtrace information -------------------------------------------
ruby(0x639a516dc55a) [0x639a516dc55a]
[0x639a512af8dd]
[0x639a512a3a31]
[0x639a513876a1]
[0x639a513877a6]
[0x639a5149b0b3]
[0x639a51487565]
[0x639a514317db]
[0x639a51433e71]
[0x639a51434295]
```

See full log at: https://gist.github.com/osyoyu/2ae4fe3e41c139703bab5c321a81dda5



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  reply	other threads:[~2025-02-02 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02  8:59 [ruby-core:120859] " osyoyu (Daisuke Aritomo) via ruby-core
2025-02-02 10:22 ` osyoyu (Daisuke Aritomo) via ruby-core [this message]
2025-02-02 23:19 ` [ruby-core:120865] " luke-gru (Luke Gruber) via ruby-core
2025-02-03  3:47 ` [ruby-core:120867] " osyoyu (Daisuke Aritomo) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-111734.20250202102240.10855@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).