From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 97FBD1F4EB for ; Wed, 19 Feb 2025 09:58:42 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=M1W+WAnm; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=YyieBO2y; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1739959090; bh=Gg4XPsLqd2pBoK/cVSnQX4cum+qGyIh+0ykN8ejLa/I=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=M1W+WAnml1JcJ/pHz2oJCHuKk7n4nnfzNg3aYb0VLAqZxprTcVsNo9ClQBbR0jZlg EHnKTkr+nXQywudZwlurFn4ehEgtyo6dQNpZFkMoxM/66KifuH076N0BfNV8vEnfsa ylpeZsNyRYHtpwvd1KTsS80NuLWM6eounlFOv6AA= Received: from nue.mailmanlists.eu (localhost [IPv6:::1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 2D009469C6 for ; Wed, 19 Feb 2025 09:58:10 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=YyieBO2y; dkim-atps=neutral Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 7294B469B8 for ; Wed, 19 Feb 2025 09:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=lnuSYn1hEeWUdcdJywRNJIftxLFCELdvHCwIY94SSOk=; b=YyieBO2y2Qd6C+XFzDzFCybPlxYvMByQ6zbVmFUNM4Cxz/yN6qqZt9Q8m4X+Gmqtaw9I 8MqLNVPj8lkVQpssRtJmajpxIF5sDP6ctFHrIGt54kLZVo4rPVTFjkaxznYkWzzYmmOf+J 3HEtf4VtYmrykSfkObNibMj9ySqpH4oKqMArxhdX0ssw/AF2JDnm4f6FUdauSCjlPcAITp wSsmHsJ+L6Ec+26IjtYsoKnYBPaYOhxJD72OMKK2fOsESTqHGZhnGiZhSBpefDq1AqsqAX 0UikeW8DPXF5bP+xR34pYRzb1mfTvSN0CEDJhlmH1qFzGLhQF/m5MKD0NGR4tMdw== Received: by recvd-69cbc48b94-rsxdm with SMTP id recvd-69cbc48b94-rsxdm-1-67B5AB2C-1A 2025-02-19 09:58:04.455024869 +0000 UTC m=+8339632.870120201 Received: from herokuapp.com (unknown) by geopod-ismtpd-27 (SG) with ESMTP id RvXUTlHoSsGUEpEQp9HTKQ for ; Wed, 19 Feb 2025 09:58:04.415 +0000 (UTC) Date: Wed, 19 Feb 2025 09:58:04 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Misc X-Redmine-Issue-Id: 20968 X-Redmine-Issue-Author: koic X-Redmine-Issue-Priority: Normal X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 97844 X-SG-EID: =?us-ascii?Q?u001=2EByjZWvxTCjdoV8K03xEuhE7KqN4thWULFLM7+oH78KY30oYB3qFthsDpL?= =?us-ascii?Q?4w4cbYa3ttBh8bAHPOnE=2FkzPba67JNu7Lnrked2?= =?us-ascii?Q?O7K9VQ=2FJax0=2FeBG9T2kkRlKcRZ4CwUyIzdBujSg?= =?us-ascii?Q?3gTY7a3QKyWPNOiudIjRlsWytSy0pycUbtpZX5+?= =?us-ascii?Q?VHkyrFt2HUtlpGhPcYTvyCZTdEJaCsWzs9j8Pi9?= =?us-ascii?Q?hvy+a3oxw6+SSiO9HETL0Hf3kpuVxMwe3Y4Kcm9?= =?us-ascii?Q?qdFq7i8t5j8vtyHj2kn+wucPGQ=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: 4RP6JAFL72HGZQ7M5OAKKYGCPQFDPHKH X-Message-ID-Hash: 4RP6JAFL72HGZQ7M5OAKKYGCPQFDPHKH X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:121122] [Ruby master Misc#20968] `Array#fetch_values` unexpected method name in stack trace List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Eregon (Benoit Daloze) via ruby-core" Cc: "Eregon (Benoit Daloze)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20968 has been updated by Eregon (Benoit Daloze). Another way to look at it is if `Array#fetch_values` was defined by a gem (e.g. by `activesupport`), then everyone would expect: ``` :211:in 'Array#fetch': index 42 outside of array bounds: -1...1 (IndexError) from /path/to/activesupport/some/file.rb:211:in 'block in Array#fetch_values' from /path/to/activesupport/some/file.rb:211:in 'Array#map!' from /path/to/activesupport/some/file.rb:211:in 'Array#fetch_values' from -e:1:in '
' ``` So the fact it's `:211` instead of `/path/to/activesupport/some/file.rb:211` in the description seems a very small expected difference, it's just defined "in a core library Ruby file" vs "in a gem Ruby file". I think this argument is strong enough on its own to not change stacktraces until a concrete problem is reported with the current core library stacktraces. --- Maybe the core library Ruby paths could be a bit nicer like `:211` then potentially editors could just open that. It would be pretty cool if users could just see the implementation of some core library methods defined in Ruby. FWIW TruffleRuby uses ` core/array.rb:211` which I think is nice and clear: ``` $ ruby -e '1.tap { raise "foo" }' -e:1:in `block in
': foo (RuntimeError) from core/kernel.rb:520:in `tap' from -e:1:in `
' ``` We could ship these core files with CRuby to make it easier to understand what's going on. We'd add a comment on top of the file explaining modifying the file would have no effect as the source is not used, only its bytecode. ---------------------------------------- Misc #20968: `Array#fetch_values` unexpected method name in stack trace https://bugs.ruby-lang.org/issues/20968#change-112044 * Author: koic (Koichi ITO) * Status: Open ---------------------------------------- It seems that the current Ruby implementation is displaying unexpected method name in stack trace. ## Expected Similar to `Hash#fetch_values`, the method name `Array#fetch_values` is expected to be displayed in the stack trace. ```console $ ruby -e '{k: 42}.fetch_values(:unknown)' -e:1:in 'Hash#fetch_values': key not found: :unknown (KeyError) from -e:1:in '
' $ ruby -e '[1].fetch_values(42)' -e:1:in 'Array#fetch_values': index 42 outside of array bounds: -1...1 (IndexError) from -e:1:in '
' ``` ## Actual The stack trace displays the `Array#fetch` method, which user is not aware of, along with the `` stack trace. ```console $ ruby -e '[1].fetch_values(42)' :211:in 'Array#fetch': index 42 outside of array bounds: -1...1 (IndexError) from :211:in 'block in Array#fetch_values' from :211:in 'Array#map!' from :211:in 'Array#fetch_values' from -e:1:in '
' ``` It likely requires an approach such as implementing it in C, as suggested in https://github.com/ruby/ruby/pull/11555. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/